Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model.h

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_bubble_model.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
index 202cae9ac8d50580859e83434a660fcb665b8e36..583ea7f167845d08ad3c1550e1196f6139c400ad 100644
--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model.h
@@ -48,6 +48,10 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Called by the view code when the "Cancel" button in clicked by the user.
void OnCancelClicked();
+ // Called by the view code when the "Nope" button in clicked by the user in
+ // update bubble.
+ void OnNopeUpdateClicked();
+
// Called by the view code when the "Never for this site." button in clicked
// by the user.
void OnNeverForThisSiteClicked();
@@ -151,6 +155,13 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
// Updates |title_| and |title_brand_link_range_| for the
// PENDING_PASSWORD_STATE.
void UpdatePendingStateTitle();
+ enum UserBehaviorOnUpdateBubble {
+ UPDATE_CLICKED,
+ NOPE_CLICKED,
+ NO_INTERACTION
+ };
+ password_manager::metrics_util::UpdatePasswordSubmissionEvent
+ GetUpdateDismissalReason(UserBehaviorOnUpdateBubble behavior);
// URL of the page from where this bubble was triggered.
GURL origin_;
password_manager::ui::State state_;
@@ -165,8 +176,13 @@ class ManagePasswordsBubbleModel : public content::WebContentsObserver {
base::string16 manage_link_;
base::string16 save_confirmation_text_;
gfx::Range save_confirmation_link_range_;
+ // If true upon destruction, the user has confirmed that she never wants to
+ // save passwords for a particular site.
+ bool is_update_bubble_;
vasilii 2015/08/21 14:59:22 The comment is totally wrong. I guess you need thi
dvadym 2015/08/21 15:31:13 Done.
password_manager::metrics_util::UIDisplayDisposition display_disposition_;
password_manager::metrics_util::UIDismissalReason dismissal_reason_;
+ password_manager::metrics_util::UpdatePasswordSubmissionEvent
+ update_password_submission_event_;
DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
};

Powered by Google App Engine
This is Rietveld 408576698