Added UMA statistics for change passwords in the Password Manager

chrome/browser/ui/passwords/manage_passwords_bubble_model.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 #define CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_
 
 #include "base/memory/scoped_vector.h"
 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
 #include "components/autofill/core/common/password_form.h"
@@ skipping 30 matching lines @@
 
   // Called by the view code when the bubble is shown.
   void OnBubbleShown(ManagePasswordsBubble::DisplayReason reason);
 
   // Called by the view code when the bubble is hidden.
   void OnBubbleHidden();
 
   // Called by the view code when the "Cancel" button in clicked by the user.
   void OnCancelClicked();
 
+  // Called by the view code when the "Nope" button in clicked by the user in
+  // update bubble.
+  void OnNopeUpdateClicked();
+
   // Called by the view code when the "Never for this site." button in clicked
   // by the user.
   void OnNeverForThisSiteClicked();
 
   // Called by the view code when the save button is clicked by the user.
   void OnSaveClicked();
 
   // Called by the view code when the update link is clicked by the user.
   void OnUpdateClicked(const autofill::PasswordForm& password_form);
 
@@ skipping 83 matching lines @@
 #endif
 
   // Upper limits on the size of the username and password fields.
   static int UsernameFieldWidth();
   static int PasswordFieldWidth();
 
  private:
   // Updates |title_| and |title_brand_link_range_| for the
   // PENDING_PASSWORD_STATE.
   void UpdatePendingStateTitle();
+  enum UserBehaviorOnUpdateBubble {
+    UPDATE_CLICKED,
+    NOPE_CLICKED,
+    NO_INTERACTION
+  };
+  password_manager::metrics_util::UpdatePasswordSubmissionEvent
+  GetUpdateDismissalReason(UserBehaviorOnUpdateBubble behavior);
   // URL of the page from where this bubble was triggered.
   GURL origin_;
   password_manager::ui::State state_;
   base::string16 title_;
   // Range of characters in the title that contains the Smart Lock Brand and
   // should point to an article. For the default title the range is empty.
   gfx::Range title_brand_link_range_;
   autofill::PasswordForm pending_password_;
   bool password_overridden_;
   ScopedVector<const autofill::PasswordForm> local_credentials_;
   ScopedVector<const autofill::PasswordForm> federated_credentials_;
   base::string16 manage_link_;
   base::string16 save_confirmation_text_;
   gfx::Range save_confirmation_link_range_;
+  // If true upon destruction, the user has confirmed that she never wants to
+  // save passwords for a particular site.
+  bool is_update_bubble_;

[vasilii, 2015/08/21 14:59:22]

The comment is totally wrong.
I guess you need this variable because |state_| may change. I suggest that you
remove this memeber and all assignments to |state_| in methods like
OnChooseCredentials(). It's not needed by production code. Some
ManagePasswordsBubbleModelTest tests will fail but you can safely remove the
checks.

[dvadym, 2015/08/21 15:31:13]

Done.

   password_manager::metrics_util::UIDisplayDisposition display_disposition_;
   password_manager::metrics_util::UIDismissalReason dismissal_reason_;
+  password_manager::metrics_util::UpdatePasswordSubmissionEvent
+      update_password_submission_event_;
 
   DISALLOW_COPY_AND_ASSIGN(ManagePasswordsBubbleModel);
 };
 
 #endif  // CHROME_BROWSER_UI_PASSWORDS_MANAGE_PASSWORDS_BUBBLE_MODEL_H_