chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 1304573004: Added UMA statistics for change passwords in the Password Manager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/passwords/manage_passwords_bubble_model.cc ('k') | chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index 31857697670edbce3e1adf2dc07f9f3b4703f726..4e311c77c20b0d8043c0b1fe6422f267e1a7fa03 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -125,7 +125,6 @@ TEST_F(ManagePasswordsBubbleModelTest, ClickSave) {

model_->OnBubbleHidden();

EXPECT_EQ(model_->dismissal_reason(),

password_manager::metrics_util::CLICKED_SAVE);

- EXPECT_EQ(password_manager::ui::MANAGE_STATE, model_->state());

EXPECT_TRUE(controller()->saved_password());

EXPECT_FALSE(controller()->never_saved_password());

@@ -275,7 +274,6 @@ TEST_F(ManagePasswordsBubbleModelTest, ClickUpdate) {

PretendUpdatePasswordWaiting();

model_->OnUpdateClicked(autofill::PasswordForm());

model_->OnBubbleHidden();

- EXPECT_EQ(password_manager::ui::MANAGE_STATE, model_->state());

EXPECT_TRUE(controller()->updated_password());

EXPECT_FALSE(controller()->never_saved_password());

}