Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 1304573004: Added UMA statistics for change passwords in the Password Manager (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/metrics/histogram_samples.h" 5 #include "base/metrics/histogram_samples.h"
6 #include "base/prefs/pref_service.h" 6 #include "base/prefs/pref_service.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "base/test/histogram_tester.h" 8 #include "base/test/histogram_tester.h"
9 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h" 9 #include "chrome/browser/ui/passwords/manage_passwords_bubble.h"
10 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h" 10 #include "chrome/browser/ui/passwords/manage_passwords_bubble_model.h"
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
118 1); 118 1);
119 } 119 }
120 120
121 TEST_F(ManagePasswordsBubbleModelTest, ClickSave) { 121 TEST_F(ManagePasswordsBubbleModelTest, ClickSave) {
122 base::HistogramTester histogram_tester; 122 base::HistogramTester histogram_tester;
123 PretendPasswordWaiting(); 123 PretendPasswordWaiting();
124 model_->OnSaveClicked(); 124 model_->OnSaveClicked();
125 model_->OnBubbleHidden(); 125 model_->OnBubbleHidden();
126 EXPECT_EQ(model_->dismissal_reason(), 126 EXPECT_EQ(model_->dismissal_reason(),
127 password_manager::metrics_util::CLICKED_SAVE); 127 password_manager::metrics_util::CLICKED_SAVE);
128 EXPECT_EQ(password_manager::ui::MANAGE_STATE, model_->state());
129 EXPECT_TRUE(controller()->saved_password()); 128 EXPECT_TRUE(controller()->saved_password());
130 EXPECT_FALSE(controller()->never_saved_password()); 129 EXPECT_FALSE(controller()->never_saved_password());
131 130
132 histogram_tester.ExpectUniqueSample( 131 histogram_tester.ExpectUniqueSample(
133 kUIDismissalReasonMetric, 132 kUIDismissalReasonMetric,
134 password_manager::metrics_util::CLICKED_SAVE, 133 password_manager::metrics_util::CLICKED_SAVE,
135 1); 134 1);
136 } 135 }
137 136
138 TEST_F(ManagePasswordsBubbleModelTest, ClickNever) { 137 TEST_F(ManagePasswordsBubbleModelTest, ClickNever) {
(...skipping 129 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 histogram_tester.ExpectUniqueSample( 267 histogram_tester.ExpectUniqueSample(
269 kUIDismissalReasonMetric, 268 kUIDismissalReasonMetric,
270 password_manager::metrics_util::AUTO_SIGNIN_TOAST_CLICKED, 269 password_manager::metrics_util::AUTO_SIGNIN_TOAST_CLICKED,
271 1); 270 1);
272 } 271 }
273 272
274 TEST_F(ManagePasswordsBubbleModelTest, ClickUpdate) { 273 TEST_F(ManagePasswordsBubbleModelTest, ClickUpdate) {
275 PretendUpdatePasswordWaiting(); 274 PretendUpdatePasswordWaiting();
276 model_->OnUpdateClicked(autofill::PasswordForm()); 275 model_->OnUpdateClicked(autofill::PasswordForm());
277 model_->OnBubbleHidden(); 276 model_->OnBubbleHidden();
278 EXPECT_EQ(password_manager::ui::MANAGE_STATE, model_->state());
279 EXPECT_TRUE(controller()->updated_password()); 277 EXPECT_TRUE(controller()->updated_password());
280 EXPECT_FALSE(controller()->never_saved_password()); 278 EXPECT_FALSE(controller()->never_saved_password());
281 } 279 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698