Chromium Code Reviews| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 0fb79261fea28362938b2a86a7eb0a8a37c3823a..7137fe39366904788e312e976735c092e0253429 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -29356,6 +29356,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| </summary> |
| </histogram> |
| +<histogram name="PasswordManager.UpdatePasswordSubmissionEvent" |
| + enum="UpdatePasswordSubmissionEvent"> |
| + <owner>dvadym@chromium.org</owner> |
| + <owner>vasilii@chromium.org</owner> |
| + <summary> |
| + Which password update event was happened and what did the user do with the |
|
Ilya Sherman
2015/08/20 00:30:51
nit: "was happened" -> "happened"
dvadym
2015/08/20 11:10:11
Done.
|
| + password update bubble. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="PasswordManager.UserStoredPasswordWithInvalidSSLCert" |
| enum="Boolean"> |
| <owner>xunlu@chromium.org</owner> |
| @@ -71952,6 +71962,21 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="2" label="Forced Full"/> |
| </enum> |
| +<enum name="UpdatePasswordSubmissionEvent" type="int"> |
| + <int value="0" label="NO_ACCOUNTS_CLICKED_UPDATE"/> |
|
Ilya Sherman
2015/08/20 00:30:51
What does this case mean? What accounts are in sc
dvadym
2015/08/20 11:10:11
It means that there is no accounts stored in the P
Ilya Sherman
2015/08/21 01:24:23
This might be a case where I'd actually recommend
dvadym
2015/08/21 14:09:53
Thanks for such comprehensive answer. I've chosen
|
| + <int value="1" label="NO_ACCOUNTS_CLICKED_NOPE"/> |
| + <int value="2" label="NO_ACCOUNTS_NO_INTERACTION"/> |
| + <int value="3" label="ONE_ACCOUNT_CLICKED_UPDATE"/> |
| + <int value="4" label="ONE_ACCOUNT_CLICKED_NOPE"/> |
| + <int value="5" label="ONE_ACCOUNT_NO_INTERACTION"/> |
| + <int value="6" label="MULTIPLE_ACCOUNTS_CLICKED_UPDATE"/> |
| + <int value="7" label="MULTIPLE_ACCOUNTS_CLICKED_NOPE"/> |
| + <int value="8" label="MULTIPLE_ACCOUNTS_NO_INTERACTION"/> |
| + <int value="9" label="PASSWORD_OVERRIDEN_CLICKED_UPDATE"/> |
| + <int value="10" label="PASSWORD_OVERRIDEN_CLICKED_NOPE"/> |
| + <int value="11" label="PASSWORD_OVERRIDEN_NO_INTERACTION"/> |
|
Ilya Sherman
2015/08/20 00:30:51
nit: "riden" -> "ridden"
dvadym
2015/08/20 11:10:11
Done.
|
| +</enum> |
| + |
| <enum name="UpdatePolicy" type="int"> |
| <int value="0" label="UPDATES_DISABLED"/> |
| <int value="1" label="AUTOMATIC_UPDATES"/> |