Added UMA statistics for change passwords in the Password Manager

components/password_manager/core/browser/password_manager_metrics_util.h

Index: components/password_manager/core/browser/password_manager_metrics_util.h
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.h b/components/password_manager/core/browser/password_manager_metrics_util.h
index 4dea78a3cc33b94ca5bb700b7781d0d856d762f3..379fd1fa0307ca3ec1dfd94a06acab776e25bedf 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.h
+++ b/components/password_manager/core/browser/password_manager_metrics_util.h
@@ -31,6 +31,8 @@ enum UIDisplayDisposition {
   AUTOMATIC_GENERATED_PASSWORD_CONFIRMATION,
   AUTOMATIC_CREDENTIAL_REQUEST,
   AUTOMATIC_SIGNIN_TOAST,
+  MANUAL_WITH_PASSWORD_PENDING_UPDATE,
+  AUTOMATIC_WITH_PASSWORD_PENDING_UPDATE,

[Ilya Sherman, 2015/08/20 00:30:51]

Should histograms.xml be updated correspondingly?

[dvadym, 2015/08/20 11:10:11]

Thanks, Done

   NUM_DISPLAY_DISPOSITIONS
 };
 
@@ -87,6 +89,23 @@ enum PasswordSubmissionEvent {
   SUBMISSION_EVENT_ENUM_COUNT
 };
 
+enum UpdatePasswordSubmissionEvent {
+  NO_ACCOUNTS_CLICKED_UPDATE,
+  NO_ACCOUNTS_CLICKED_NOPE,
+  NO_ACCOUNTS_NO_INTERACTION,
+  ONE_ACCOUNT_CLICKED_UPDATE,
+  ONE_ACCOUNT_CLICKED_NOPE,
+  ONE_ACCOUNT_NO_INTERACTION,
+  MULTIPLE_ACCOUNTS_CLICKED_UPDATE,
+  MULTIPLE_ACCOUNTS_CLICKED_NOPE,
+  MULTIPLE_ACCOUNTS_NO_INTERACTION,
+  PASSWORD_OVERRIDEN_CLICKED_UPDATE,
+  PASSWORD_OVERRIDEN_CLICKED_NOPE,
+  PASSWORD_OVERRIDEN_NO_INTERACTION,

[Ilya Sherman, 2015/08/20 00:30:51]

nit: "riden" -> "ridden"

[dvadym, 2015/08/20 11:10:11]

Done.

+  UPDATE_PASSWORD_EVENT_COUNT,

[vasilii, 2015/08/19 13:01:18]

It should be the last one.

+  NO_UPDATE_SUBMISSION

[vasilii, 2015/08/19 13:01:18]

What is this case?

[dvadym, 2015/08/20 11:10:11]

I've introduce it in order to have default value for convenience of checking
that nothing happened. In UIDismissalReason the same pattern is used. Probably
it's worth to make comment. What do you think?

[vasilii, 2015/08/20 15:11:48]

Sure. Note that there is always the dismissal reason. So
ManagePasswordsBubbleModel::OnBubbleHidden should always report something.

+};
+
 // We monitor the performance of the save password heuristic for a handful of
 // domains. For privacy reasons we are not reporting UMA signals by domain, but
 // by a domain group. A domain group can contain multiple domains, and a domain
@@ -144,6 +163,9 @@ void LogPasswordSyncState(PasswordSyncState state);
 // Log submission events related to generation.
 void LogPasswordGenerationSubmissionEvent(PasswordSubmissionEvent event);
 
+// Log submission events related to password update.
+void LogUpdatePasswordSubmissionEvent(UpdatePasswordSubmissionEvent event);
+
 }  // namespace metrics_util
 
 }  // namespace password_manager