Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1304563003: Move //components/metrics/compression_utils into standalone component (Closed)

Created:
5 years, 4 months ago by blundell
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, maxbogue+watch_chromium.org, zea+watch_chromium.org, droger+watchlist_chromium.org, blundell+watchlist_chromium.org, sdefresne+watchlist_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, asvitkine+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move //components/metrics/compression_utils into standalone component This file is used by code in //chrome/browser/metrics/variations that itself is slated for componentization. As //components/metrics depends on //components/variations, the code in question would not be able to be componentized into //components/variations. To enable that, this CL moves compression_utils* to a standalone lower-level component. BUG=516662, 515695 TBR=agl Committed: https://crrev.com/64fedf1a9022ce13d9885cf3bebac417f4a73b45 Cr-Commit-Position: refs/heads/master@{#345309}

Patch Set 1 #

Patch Set 2 : Fix GN #

Patch Set 3 : Rebase #

Patch Set 4 : Add dep #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -327 lines) Patch
M chrome/browser/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/variations/variations_seed_store_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/BUILD.gn View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/components.gyp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 chunks +6 lines, -2 lines 0 comments Download
A + components/compression.gypi View 1 chunk +8 lines, -8 lines 0 comments Download
A + components/compression/BUILD.gn View 1 chunk +7 lines, -9 lines 0 comments Download
A + components/compression/DEPS View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + components/compression/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + components/compression/compression_utils.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/compression/compression_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
A + components/compression/compression_utils_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/metrics.gypi View 2 chunks +1 line, -3 lines 0 comments Download
M components/metrics/BUILD.gn View 1 2 3 4 3 chunks +1 line, -4 lines 0 comments Download
M components/metrics/DEPS View 1 chunk +1 line, -1 line 0 comments Download
D components/metrics/compression_utils.h View 1 chunk +0 lines, -22 lines 0 comments Download
D components/metrics/compression_utils.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D components/metrics/compression_utils_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
M components/metrics/metrics_service_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M components/metrics/persisted_logs.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/metrics/persisted_logs_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sync/internal_api/http_bridge.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
blundell
5 years, 4 months ago (2015-08-19 11:16:49 UTC) #2
Alexei Svitkine (slow)
LGTM Please also add crbug.com/515695 to the BUG= line.
5 years, 4 months ago (2015-08-24 15:54:59 UTC) #3
blundell
On 2015/08/24 15:54:59, Alexei Svitkine (OOO Aug15-24) wrote: > LGTM > > Please also add ...
5 years, 4 months ago (2015-08-25 07:58:39 UTC) #4
blundell
TBR=agl for the dependency from //components/compression to //third_party/zlib: it's just a move of the pre-existing ...
5 years, 4 months ago (2015-08-25 11:09:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304563003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304563003/80001
5 years, 4 months ago (2015-08-25 11:09:28 UTC) #9
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-25 12:22:37 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 12:23:16 UTC) #11
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/64fedf1a9022ce13d9885cf3bebac417f4a73b45
Cr-Commit-Position: refs/heads/master@{#345309}

Powered by Google App Engine
This is Rietveld 408576698