cc/trees/layer_sorter.cc - Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_sorter.cc

Issue 130443005: [#5] Pass gfx structs by const ref (gfx::Vector2dF) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporated the review comments Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_sorter.cc

diff --git a/cc/trees/layer_sorter.cc b/cc/trees/layer_sorter.cc

index 9287f19c05ac598b492d7d11db1133b627426e31..e171fe01120f6389931b1acb403581968e7126db 100644

--- a/cc/trees/layer_sorter.cc

+++ b/cc/trees/layer_sorter.cc

@@ -23,7 +23,8 @@ namespace cc {

// the test scene went away.

const float k_layer_epsilon = 1e-4f;

-inline static float PerpProduct(gfx::Vector2dF u, gfx::Vector2dF v) {

+inline static float PerpProduct(const gfx::Vector2dF& u,

+ const gfx::Vector2dF& v) {

return u.x() * v.y() - u.y() * v.x();

}

« no previous file with comments | « cc/test/animation_test_common.cc ('k') | cc/trees/layer_tree_host_common.cc » ('j') | no next file with comments »