chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json - Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more missing include Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc ('K') | « chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

diff --git a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

new file mode 100644

index 0000000000000000000000000000000000000000..b85731b9f49809450db6e2b08eebeb8520baa565

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json

@@ -0,0 +1,19 @@

+ "name": "An extension that tries to overwrite system keybindings",

+ "version": "1.0",

+ "manifest_version": 2,

+ "background": {

+ "scripts": ["background.js"]

+ },

+ "permissions": ["activeTab"],

+ "commands": {

+ "red": {

+ "suggested_key": "Ctrl+F",

+ "description": "Make the page red"

+ },

+ "blue": {

+ "suggested_key": "Alt+Shift+F",

+ "description": "Make the page blue"

+ }