chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js - Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

Issue 13044014: Make sure manifest specified shortcut for Extension Command can not override the built-in shortcuts. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: One more missing include Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc ('K') | « chrome/browser/ui/views/extensions/extension_keybinding_registry_views.cc ('k') | chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/manifest.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

diff --git a/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

new file mode 100644

index 0000000000000000000000000000000000000000..cef236497cec899f254238c528beae93ba4e4116

--- /dev/null

+++ b/chrome/test/data/extensions/api_test/keybinding/dont_overwrite_system/background.js

@@ -0,0 +1,11 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// Called when the user activates the command.

+chrome.commands.onCommand.addListener(function(command) {

+ chrome.tabs.executeScript(null, {

+ code: "document.body.bgColor='" + command + "'" });

+});

+chrome.test.notifyPass();