Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issue 1304373006: trifurcate blit_mask_d32_a8 into _black, _opaque, _general. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

trifurcate blit_mask_d32_a8 into _black, _opaque, _general. We used to split the NEON code this way, and just had one path for SSE. It's unclear to me testing locally if there's any major win here, but there's at least a small one. No pixel diffs or even any math changes, just folding constants through. BUG=skia:4117 Committed: https://skia.googlesource.com/skia/+/5015176adf046ef906a2313b6e6b64b72cc84898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M src/opts/SkBlitMask_opts.h View 3 chunks +53 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304373006/1
5 years, 3 months ago (2015-08-26 16:58:21 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 17:06:49 UTC) #4
mtklein_C
5 years, 3 months ago (2015-08-26 17:29:16 UTC) #6
reed1
if its faster, it seems easy enough to read/maintain lgtm
5 years, 3 months ago (2015-08-26 19:14:16 UTC) #7
mtklein_C
On 2015/08/26 19:14:16, reed1 wrote: > if its faster, it seems easy enough to read/maintain ...
5 years, 3 months ago (2015-08-26 19:34:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304373006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304373006/1
5 years, 3 months ago (2015-08-26 19:34:39 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 19:35:17 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5015176adf046ef906a2313b6e6b64b72cc84898

Powered by Google App Engine
This is Rietveld 408576698