Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1304303006: [Android] Don't use a device blacklist if one isn't provided. (RELAND) (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Don't use a device blacklist if one isn't provided. (RELAND) This is a reland of https://codereview.chromium.org/1314823011 BUG=517709 Committed: https://crrev.com/7555cbb5daf4fb30cb56de9ed4dd8bcd565b5cf6 Cr-Commit-Position: refs/heads/master@{#348158}

Patch Set 1 : original #

Patch Set 2 : fixed #

Patch Set 3 : add blacklist to host_info and the old buildbot scripts #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -80 lines) Patch
M build/android/adb_install_apk.py View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M build/android/adb_reverse_forwarder.py View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/buildbot/bb_device_status_check.py View 1 2 7 chunks +13 lines, -10 lines 0 comments Download
M build/android/buildbot/bb_device_steps.py View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M build/android/devil/android/device_blacklist.py View 2 chunks +5 lines, -22 lines 0 comments Download
M build/android/devil/android/device_utils.py View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M build/android/enable_asserts.py View 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/provision_devices.py View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M build/android/pylib/local/device/local_device_environment.py View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M build/android/screenshot.py View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/test_runner.py View 1 2 1 chunk +3 lines, -6 lines 0 comments Download
M build/android/tombstones.py View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M build/android/update_verification.py View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M testing/scripts/host_info.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (4 generated)
jbudorick
5 years, 3 months ago (2015-09-04 22:59:01 UTC) #2
jbudorick
phajdan.jr: ptal at testing/scripts/ rnephew: ping
5 years, 3 months ago (2015-09-10 00:57:12 UTC) #4
rnephew (Wrong account)
On 2015/09/10 00:57:12, jbudorick wrote: > phajdan.jr: ptal at testing/scripts/ > rnephew: ping lgtm
5 years, 3 months ago (2015-09-10 01:52:48 UTC) #5
Paweł Hajdan Jr.
LGTM
5 years, 3 months ago (2015-09-10 14:31:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304303006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304303006/40001
5 years, 3 months ago (2015-09-10 14:32:48 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-10 15:38:27 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/7555cbb5daf4fb30cb56de9ed4dd8bcd565b5cf6 Cr-Commit-Position: refs/heads/master@{#348158}
5 years, 3 months ago (2015-09-10 15:39:13 UTC) #11
jbudorick
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/1334803002/ by jbudorick@chromium.org. ...
5 years, 3 months ago (2015-09-10 17:23:43 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:10:56 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7555cbb5daf4fb30cb56de9ed4dd8bcd565b5cf6
Cr-Commit-Position: refs/heads/master@{#348158}

Powered by Google App Engine
This is Rietveld 408576698