Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: src/gpu/gl/GrGLVertexArray.h

Issue 130423013: Use vertex buffer objects instead of client side arrays in fixed-function codepaths (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/GrGLNoOpInterface.cpp ('k') | src/gpu/gl/GrGLVertexArray.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLVertexArray.h
diff --git a/src/gpu/gl/GrGLVertexArray.h b/src/gpu/gl/GrGLVertexArray.h
index 5cc7b5fd5bec7593cfd7f46b89acd454b5b157d9..8a61f1a2c6055dc90bb00e5aa77ab21d73acc4ba 100644
--- a/src/gpu/gl/GrGLVertexArray.h
+++ b/src/gpu/gl/GrGLVertexArray.h
@@ -51,9 +51,6 @@ class GrGLAttribArrayState {
public:
explicit GrGLAttribArrayState(int arrayCount = 0) {
this->resize(arrayCount);
- // glVertexPointer doesn't have a normalization param.
- fFixedFunctionVertexArray.fNormalized = false;
- fUnusedFixedFunctionArraysDisabled = false;
}
void resize(int newCount) {
@@ -77,26 +74,17 @@ public:
GrGLsizei stride,
GrGLvoid* offset);
- void setFixedFunctionVertexArray(const GrGpuGL*,
- GrGLVertexBuffer*,
- GrGLint size,
- GrGLenum type,
- GrGLsizei stride,
- GrGLvoid* offset);
-
/**
* This function disables vertex attribs not present in the mask. It is assumed that the
* GrGLAttribArrayState is tracking the state of the currently bound vertex array object.
*/
- void disableUnusedArrays(const GrGpuGL*, uint64_t usedAttribArrayMask, bool usingFFVertexArray);
+ void disableUnusedArrays(const GrGpuGL*, uint64_t usedAttribArrayMask);
void invalidate() {
int count = fAttribArrayStates.count();
for (int i = 0; i < count; ++i) {
fAttribArrayStates[i].invalidate();
}
- fFixedFunctionVertexArray.invalidate();
- fUnusedFixedFunctionArraysDisabled = false;
}
void notifyVertexBufferDelete(GrGLuint id) {
@@ -107,10 +95,6 @@ public:
fAttribArrayStates[i].invalidate();
}
}
- if (fFixedFunctionVertexArray.fAttribPointerIsValid &&
- id == fFixedFunctionVertexArray.fVertexBufferID) {
- fFixedFunctionVertexArray.invalidate();
- }
}
/**
@@ -140,13 +124,6 @@ private:
};
SkSTArray<16, AttribArrayState, true> fAttribArrayStates;
-
- // Tracks the array specified by glVertexPointer.
- AttribArrayState fFixedFunctionVertexArray;
-
- // Tracks whether we've disabled the other fixed function arrays that we don't
- // use (e.g. glNormalPointer).
- bool fUnusedFixedFunctionArraysDisabled;
};
/**
« no previous file with comments | « src/gpu/gl/GrGLNoOpInterface.cpp ('k') | src/gpu/gl/GrGLVertexArray.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698