Cast:Updating logging stats

media/cast/logging/logging_impl.h

Index: media/cast/logging/logging_impl.h
diff --git a/media/cast/logging/logging_impl.h b/media/cast/logging/logging_impl.h
index bf518699c230dd37ae722c0c8a16fcd8fa2431a4..51646ef14cf20345ecb33e022649058d30dc2cf2 100644
--- a/media/cast/logging/logging_impl.h
+++ b/media/cast/logging/logging_impl.h
@@ -62,18 +62,24 @@ class LoggingImpl : public base::NonThreadSafe {
                           int value);
 
   // Get raw data.
-  FrameRawMap GetFrameRawData();
-  PacketRawMap GetPacketRawData();
-  GenericRawMap GetGenericRawData();
-  AudioRtcpRawMap GetAudioRtcpRawData();
-  VideoRtcpRawMap GetVideoRtcpRawData();
-
-  // Get stats only (computed when called). Triggers UMA stats when enabled.
-  const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
-  const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
-  const GenericStatsMap* GetGenericStatsData();
-
-  // Reset raw logging data.
+  // Pointers are owned by the logging class, and are assumed valid on the main

[imcheng, 2014/01/23 21:17:18]

You are returning a copy of the data though, so this comment doesn't apply.

[mikhal1, 2014/01/23 23:02:17]

Done.

+  // thread until Reset is called.
+  FrameRawMap GetFrameRawData() const;
+  PacketRawMap GetPacketRawData() const;
+  GenericRawMap GetGenericRawData() const;
+
+  // Get the RTCP data and reset the data.
+  AudioRtcpRawMap GetAndResetAudioRtcpRawData();
+  VideoRtcpRawMap GetAndResetVideoRtcpRawData();
+
+  // Get stats only.
+  // Pointers are owned by the logging class, and are assumed valid on the main

[imcheng, 2014/01/23 21:17:18]

Same here, the code was changed from returning a pointer to a copy of the map so
this comment no longer applies. Just say it returns a copy of the data.

[mikhal1, 2014/01/23 23:02:17]

Done.

+  // thread until Reset is called.
+  FrameStatsMap GetFrameStatsData() const;
+  PacketStatsMap GetPacketStatsData() const;
+  GenericStatsMap GetGenericStatsData() const;
+
+  // Reset raw logging data (this does not reset the RTCP raw data).
   void ResetRaw();
   // Reset stats logging data.
   void ResetStats();