Cast:Updating logging stats

media/cast/logging/logging_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 #define MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 
 // Generic class that handles event logging for the cast library.
 // Logging has three possible optional forms:
 // 1. Raw data and stats accessible by the application.
 // 2. UMA stats.
@@ skipping 44 matching lines @@
                          uint32 frame_id,
                          uint16 packet_id,
                          uint16 max_packet_id,
                          size_t size);
 
   void InsertGenericEvent(const base::TimeTicks& time_of_event,
                           CastLoggingEvent event,
                           int value);
 
   // Get raw data.
-  FrameRawMap GetFrameRawData();
-  PacketRawMap GetPacketRawData();
-  GenericRawMap GetGenericRawData();
-  AudioRtcpRawMap GetAudioRtcpRawData();
-  VideoRtcpRawMap GetVideoRtcpRawData();
+  // Pointers are owned by the logging class, and are assumed valid on the main

[imcheng, 2014/01/23 21:17:18]

You are returning a copy of the data though, so this comment doesn't apply.

[mikhal1, 2014/01/23 23:02:17]

Done.

+  // thread until Reset is called.
+  FrameRawMap GetFrameRawData() const;
+  PacketRawMap GetPacketRawData() const;
+  GenericRawMap GetGenericRawData() const;
 
-  // Get stats only (computed when called). Triggers UMA stats when enabled.
-  const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
-  const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
-  const GenericStatsMap* GetGenericStatsData();
+  // Get the RTCP data and reset the data.
+  AudioRtcpRawMap GetAndResetAudioRtcpRawData();
+  VideoRtcpRawMap GetAndResetVideoRtcpRawData();
 
-  // Reset raw logging data.
+  // Get stats only.
+  // Pointers are owned by the logging class, and are assumed valid on the main

[imcheng, 2014/01/23 21:17:18]

Same here, the code was changed from returning a pointer to a copy of the map so
this comment no longer applies. Just say it returns a copy of the data.

[mikhal1, 2014/01/23 23:02:17]

Done.

+  // thread until Reset is called.
+  FrameStatsMap GetFrameStatsData() const;
+  PacketStatsMap GetPacketStatsData() const;
+  GenericStatsMap GetGenericStatsData() const;
+
+  // Reset raw logging data (this does not reset the RTCP raw data).
   void ResetRaw();
   // Reset stats logging data.
   void ResetStats();
 
  private:
   void InsertGenericUmaEvent(CastLoggingEvent event, int value);
   scoped_refptr<base::TaskRunner> main_thread_proxy_;
   const CastLoggingConfig config_;
   LoggingRaw raw_;
   LoggingStats stats_;
 
   DISALLOW_COPY_AND_ASSIGN(LoggingImpl);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_LOGGING_LOGGING_IMPL_H_