Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304193004: DevTools: [timeline] Include other thread costs in overview (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
Reviewers:
caseq, yurys
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: [timeline] Include other thread costs in overview BUG=521444 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201144

Patch Set 1 #

Total comments: 6

Patch Set 2 : addressing comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -59 lines) Patch
M Source/devtools/front_end/timeline/TimelineEventOverview.js View 1 5 chunks +60 lines, -56 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
alph
5 years, 3 months ago (2015-08-24 21:23:12 UTC) #2
caseq
https://codereview.chromium.org/1304193004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1304193004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode333 Source/devtools/front_end/timeline/TimelineEventOverview.js:333: this._model.virtualThreads().forEach(function (thread) { drawThreadEvents.call(this, thread.events); }, this); extract a ...
5 years, 3 months ago (2015-08-25 01:37:56 UTC) #3
alph
https://codereview.chromium.org/1304193004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js File Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/1304193004/diff/1/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode333 Source/devtools/front_end/timeline/TimelineEventOverview.js:333: this._model.virtualThreads().forEach(function (thread) { drawThreadEvents.call(this, thread.events); }, this); On 2015/08/25 ...
5 years, 3 months ago (2015-08-25 17:29:26 UTC) #4
alph
5 years, 3 months ago (2015-08-25 17:39:47 UTC) #6
caseq
lgtm
5 years, 3 months ago (2015-08-25 17:44:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304193004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304193004/20001
5 years, 3 months ago (2015-08-25 17:48:46 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 18:59:28 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201144

Powered by Google App Engine
This is Rietveld 408576698