Source/devtools/front_end/timeline/TimelinePanel.js - Issue 1304193004: DevTools: [timeline] Include other thread costs in overview

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelinePanel.js

Issue 1304193004: DevTools: [timeline] Include other thread costs in overview (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressing comments Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/devtools/front_end/timeline/TimelineEventOverview.js ('k') | Source/devtools/front_end/timeline/timelinePanel.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/devtools/front_end/timeline/TimelinePanel.js

diff --git a/Source/devtools/front_end/timeline/TimelinePanel.js b/Source/devtools/front_end/timeline/TimelinePanel.js

index b5b15fdbaccc67c638ca57d5a808fe29a38281f4..d37b2416bb0fbd2daf5ff63f3da8863c711d1954 100644

--- a/Source/devtools/front_end/timeline/TimelinePanel.js

+++ b/Source/devtools/front_end/timeline/TimelinePanel.js

@@ -600,7 +600,7 @@ WebInspector.TimelinePanel.prototype = {

this._overviewControls.push(new WebInspector.TimelineEventOverview.Input(this._model));

this._overviewControls.push(new WebInspector.TimelineEventOverview.Responsiveness(this._model, this._frameModel()));

this._overviewControls.push(new WebInspector.TimelineEventOverview.Frames(this._model, this._frameModel()));

- this._overviewControls.push(new WebInspector.TimelineEventOverview.MainThread(this._model));

+ this._overviewControls.push(new WebInspector.TimelineEventOverview.CPUActivity(this._model));

this._overviewControls.push(new WebInspector.TimelineEventOverview.Network(this._model));

}

this.element.classList.toggle("timeline-overview-frames-mode", isFrameMode);