Plumbing SSLPrivateKey

net/ssl/client_cert_store_win.cc

Index: net/ssl/client_cert_store_win.cc
diff --git a/net/ssl/client_cert_store_win.cc b/net/ssl/client_cert_store_win.cc
index 2e9763ffdb269b77ac58c18735ece8f04ceb053f..f8902d6e2eb9007dced318f7d8f316b81d2c040c 100644
--- a/net/ssl/client_cert_store_win.cc
+++ b/net/ssl/client_cert_store_win.cc
@@ -129,6 +129,10 @@ void GetClientCertsImpl(HCERTSTORE cert_store,
       if (ok)
         intermediates.push_back(copied_intermediate);
     }
+    // TODO(svaldez): Create Fake X509Certificate using CreateFromBytes and
+    // then return a tuple of the cert and SSLPrivateKey callback to create
+    // an SSLPrivateKey from the actual cert_context. Probably change
+    // CertificateList to be a pair<X509Certificate, SSLPrivateKeyCallback>

[davidben, 2015/09/25 20:10:11]

Nit: Rather than "Fake X509Certificate", I would maybe say:

TODO(svaldez): cert wraps cert_context2 which may be backed by a smartcard with
threading difficulties. Instead, create a fresh X509Certificate with
CreateFromBytes and route cert_context2 into the SSLPrivateKey. Probably change
CertificateList to be a pair<X509Certificate, SSLPrivateKeyCAllback>.
https://crbug.com/<bug-here>

[svaldez, 2015/09/28 16:54:53]

Done.

     scoped_refptr<X509Certificate> cert = X509Certificate::CreateFromHandle(
         cert_context2, intermediates);
     selected_certs->push_back(cert);