Plumbing SSLPrivateKey

net/ssl/client_cert_store_win.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ssl/client_cert_store_win.h"
 
 #include <algorithm>
 #include <string>
 
 #define SECURITY_WIN32  // Needs to be defined before including security.h
@@ skipping 111 matching lines @@
     for (DWORD i = 1; i < chain_context->rgpChain[0]->cElement; ++i) {
       PCCERT_CONTEXT chain_intermediate =
           chain_context->rgpChain[0]->rgpElement[i]->pCertContext;
       PCCERT_CONTEXT copied_intermediate = NULL;
       ok = CertAddCertificateContextToStore(NULL, chain_intermediate,
                                             CERT_STORE_ADD_USE_EXISTING,
                                             &copied_intermediate);
       if (ok)
         intermediates.push_back(copied_intermediate);
     }
+    // TODO(svaldez): Create Fake X509Certificate using CreateFromBytes and
+    // then return a tuple of the cert and SSLPrivateKey callback to create
+    // an SSLPrivateKey from the actual cert_context. Probably change
+    // CertificateList to be a pair<X509Certificate, SSLPrivateKeyCallback>

[davidben, 2015/09/25 20:10:11]

Nit: Rather than "Fake X509Certificate", I would maybe say:

TODO(svaldez): cert wraps cert_context2 which may be backed by a smartcard with
threading difficulties. Instead, create a fresh X509Certificate with
CreateFromBytes and route cert_context2 into the SSLPrivateKey. Probably change
CertificateList to be a pair<X509Certificate, SSLPrivateKeyCAllback>.
https://crbug.com/<bug-here>

[svaldez, 2015/09/28 16:54:53]

Done.

     scoped_refptr<X509Certificate> cert = X509Certificate::CreateFromHandle(
         cert_context2, intermediates);
     selected_certs->push_back(cert);
     CertFreeCertificateContext(cert_context2);
     for (size_t i = 0; i < intermediates.size(); ++i)
       CertFreeCertificateContext(intermediates[i]);
   }
 
   std::sort(selected_certs->begin(), selected_certs->end(),
             x509_util::ClientCertSorter());
@@ skipping 59 matching lines @@
     // copy).
     if (!CertFreeCertificateContext(cert))
       return false;
   }
 
   GetClientCertsImpl(test_store.get(), request, selected_certs);
   return true;
 }
 
 }  // namespace net