Issue 1304133002: Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1304133002: Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (Closed)

Created:
5 years, 4 months ago by yoichio

Modified:
5 years, 4 months ago

Reviewers:
tkent, yosin_UTC9

CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (patchset #1 id:1 of https://codereview.chromium.org/1306743002/ ) Reason for revert: This patch misused each other. See: https://codereview.chromium.org/1310433004/ Original issue's description: > [Editing][Codehealth] Replace Position::uptream/downstream to > mostBackward/ForwardCaretPosition > > Position::upstream calls just VisibleUnit.cpp::mostForwardCaretPosition and also > downstream: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/c > ore/editing/Position.cpp&l=484&cl=GROK > > This CL replaces it. > We will replace all upstream/downstream and remove them. > > BUG=518738 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200977 TBR=yosin@chromium.org,tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518738 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200978

Patch Set 1 #

Created: 5 years, 4 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	Source/core/layout/HitTestResult.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/layout/LayoutObject.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/layout/LayoutView.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

yoichio

5 years, 4 months ago (2015-08-21 10:10:54 UTC) #1

Created Revert of [Editing][Codehealth] Replace Position::uptream/downstream to
mostBackward/ForwardCaretPosition.

Expand Messages | Collapse Messages