Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1489)

Unified Diff: Source/core/layout/LayoutObject.cpp

Issue 1304133002: Revert of [Editing][Codehealth] Replace Position::uptream/downstream to mostBackward/ForwardCaretPosition. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/layout/HitTestResult.cpp ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/layout/LayoutObject.cpp
diff --git a/Source/core/layout/LayoutObject.cpp b/Source/core/layout/LayoutObject.cpp
index b1faf1809cf4e33a37ef7322e8949fa327f8fde3..28c61e1fc62b67b095b35bab84d089161fb73d33 100644
--- a/Source/core/layout/LayoutObject.cpp
+++ b/Source/core/layout/LayoutObject.cpp
@@ -2992,10 +2992,10 @@
if (!node->hasEditableStyle()) {
// If it can be found, we prefer a visually equivalent position that is editable.
const Position position = Position(node, offset);
- Position candidate = mostBackwardCaretPosition(position, CanCrossEditingBoundary);
+ Position candidate = position.downstream(CanCrossEditingBoundary);
if (candidate.anchorNode()->hasEditableStyle())
return PositionWithAffinity(candidate, affinity);
- candidate = mostForwardCaretPosition(position, CanCrossEditingBoundary);
+ candidate = position.upstream(CanCrossEditingBoundary);
if (candidate.anchorNode()->hasEditableStyle())
return PositionWithAffinity(candidate, affinity);
}
« no previous file with comments | « Source/core/layout/HitTestResult.cpp ('k') | Source/core/layout/LayoutView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698