Issue 13041004: remove redundant DCHECK that a size_t variable >= 0

Issue 13041004: remove redundant DCHECK that a size_t variable >= 0 (Closed)

Created:
7 years, 9 months ago by mostynb%opera.com

Modified:
7 years, 9 months ago

Reviewers:
kaiwang, jar (doing other things)

CC:
chromium-reviews, MAD, erikwright+watch_chromium.org, Ilya Sherman, jar (doing other things)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

remove redundant DCHECK that a size_t variable >= 0 SampleVector::GetCountAtIndex has a DCHECK which checks that a size_t variable is >= 0 and then some other condition. But size_t is an unsigned type so the first part of the check is useless (and it gives an error because of this with clang).

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	base/metrics/sample_vector.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb%opera.com@gtempaccount.com/13041004/1

7 years, 9 months ago (2013-03-25 19:54:47 UTC) #4

commit-bot: I haz the power

Presubmit check for 13041004-1 failed and returned exit status 1. INFO:root:Found 1 file(s). INFO:PRESUBMIT:Valid authors ...

7 years, 9 months ago (2013-03-25 19:54:48 UTC) #5

mostynb%opera.com

Oops, I will try again once I have fixed my account.

7 years, 9 months ago (2013-03-25 20:03:37 UTC) #6

mostynb%opera.com

7 years, 9 months ago (2013-03-25 21:32:02 UTC) #7

Uploaded using a "more correct" account here (I will close this issue):
https://codereview.chromium.org/13006014/

Expand Messages | Collapse Messages