Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1304043002: Make classes and structures in core/dom fast-allocated. (Closed)

Created:
5 years, 4 months ago by tasak
Modified:
5 years, 4 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-style_chromium.org, aboxhall, blink-reviews-events_chromium.org, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, dglazkov+blink, blink-reviews-dom_chromium.org, nektarios, je_julie, dmazzoni, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/dom fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200979

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -12 lines) Patch
M Source/core/dom/AXObjectCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Attribute.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/AttributeCollection.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/CSSSelectorWatch.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMArrayPiece.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/DOMNodeIds.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentEncodingData.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentFullscreen.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentLifecycle.h View 4 chunks +5 lines, -0 lines 0 comments Download
M Source/core/dom/DocumentOrderedMap.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/ElementDataCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ElementFullscreen.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/ElementTraversal.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/Fullscreen.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/IconURL.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/IgnoreDestructiveWriteCountIncrementer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/IncrementLoadEventDelayCount.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/Microtask.h View 3 chunks +2 lines, -3 lines 0 comments Download
M Source/core/dom/MutationObserverInterestGroup.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/MutationObserverRegistration.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeListsNodeData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/NodeTraversal.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/NthIndexCache.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/QualifiedName.h View 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/ScopedWindowFocusAllowedIndicator.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/ScriptLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/SpaceSplitString.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/dom/StyleChangeReason.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/StyleEngine.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/SuspendableTask.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/dom/TextLinkColors.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/dom/ViewportDescription.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/WeakIdentifierMap.h View 1 4 chunks +4 lines, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElement.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementCallbackQueue.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementDescriptorHash.h View 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementException.h View 3 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskDispatcher.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskImportStep.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/dom/custom/CustomElementMicrotaskStep.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementProcessingStep.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementScheduler.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/custom/CustomElementUpgradeCandidateMap.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/dom/shadow/ComposedTreeTraversal.h View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tasak
Would you review this CL?
5 years, 4 months ago (2015-08-21 06:02:15 UTC) #2
haraken
LGTM
5 years, 4 months ago (2015-08-21 07:11:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304043002/20001
5 years, 4 months ago (2015-08-21 07:12:27 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/93803)
5 years, 4 months ago (2015-08-21 08:45:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1304043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1304043002/20001
5 years, 4 months ago (2015-08-21 10:00:53 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:33:24 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200979

Powered by Google App Engine
This is Rietveld 408576698