Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: Source/core/dom/DOMTokenList.h

Issue 130403008: Update DOMTokenList::value() to return a const reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.h ('k') | Source/core/html/ClassList.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/DOMTokenList.h
diff --git a/Source/core/dom/DOMTokenList.h b/Source/core/dom/DOMTokenList.h
index bdaf34de64418a2ed14dd49cf2883851a2eff5f5..bd5204e9f12f726caace85316090e240137158de 100644
--- a/Source/core/dom/DOMTokenList.h
+++ b/Source/core/dom/DOMTokenList.h
@@ -57,12 +57,12 @@ public:
bool toggle(const AtomicString&, ExceptionState&);
bool toggle(const AtomicString&, bool force, ExceptionState&);
- AtomicString toString() const { return value(); }
+ const AtomicString& toString() const { return value(); }
virtual Element* element() { return 0; }
protected:
- virtual AtomicString value() const = 0;
+ virtual const AtomicString& value() const = 0;
virtual void setValue(const AtomicString&) = 0;
virtual void addInternal(const AtomicString&);
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.h ('k') | Source/core/html/ClassList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698