Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: Source/core/dom/DOMTokenList.h

Issue 130403008: Update DOMTokenList::value() to return a const reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.h ('k') | Source/core/html/ClassList.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 virtual const AtomicString item(unsigned index) const = 0; 50 virtual const AtomicString item(unsigned index) const = 0;
51 51
52 bool contains(const AtomicString&, ExceptionState&) const; 52 bool contains(const AtomicString&, ExceptionState&) const;
53 virtual void add(const Vector<String>&, ExceptionState&); 53 virtual void add(const Vector<String>&, ExceptionState&);
54 void add(const AtomicString&, ExceptionState&); 54 void add(const AtomicString&, ExceptionState&);
55 virtual void remove(const Vector<String>&, ExceptionState&); 55 virtual void remove(const Vector<String>&, ExceptionState&);
56 void remove(const AtomicString&, ExceptionState&); 56 void remove(const AtomicString&, ExceptionState&);
57 bool toggle(const AtomicString&, ExceptionState&); 57 bool toggle(const AtomicString&, ExceptionState&);
58 bool toggle(const AtomicString&, bool force, ExceptionState&); 58 bool toggle(const AtomicString&, bool force, ExceptionState&);
59 59
60 AtomicString toString() const { return value(); } 60 const AtomicString& toString() const { return value(); }
61 61
62 virtual Element* element() { return 0; } 62 virtual Element* element() { return 0; }
63 63
64 protected: 64 protected:
65 virtual AtomicString value() const = 0; 65 virtual const AtomicString& value() const = 0;
66 virtual void setValue(const AtomicString&) = 0; 66 virtual void setValue(const AtomicString&) = 0;
67 67
68 virtual void addInternal(const AtomicString&); 68 virtual void addInternal(const AtomicString&);
69 virtual bool containsInternal(const AtomicString&) const = 0; 69 virtual bool containsInternal(const AtomicString&) const = 0;
70 virtual void removeInternal(const AtomicString&); 70 virtual void removeInternal(const AtomicString&);
71 71
72 static bool validateToken(const String&, ExceptionState&); 72 static bool validateToken(const String&, ExceptionState&);
73 static bool validateTokens(const Vector<String>&, ExceptionState&); 73 static bool validateTokens(const Vector<String>&, ExceptionState&);
74 static AtomicString addToken(const AtomicString&, const AtomicString&); 74 static AtomicString addToken(const AtomicString&, const AtomicString&);
75 static AtomicString addTokens(const AtomicString&, const Vector<String>&); 75 static AtomicString addTokens(const AtomicString&, const Vector<String>&);
76 static AtomicString removeToken(const AtomicString&, const AtomicString&); 76 static AtomicString removeToken(const AtomicString&, const AtomicString&);
77 static AtomicString removeTokens(const AtomicString&, const Vector<String>&) ; 77 static AtomicString removeTokens(const AtomicString&, const Vector<String>&) ;
78 }; 78 };
79 79
80 } // namespace WebCore 80 } // namespace WebCore
81 81
82 #endif // DOMTokenList_h 82 #endif // DOMTokenList_h
OLDNEW
« no previous file with comments | « Source/core/dom/DOMSettableTokenList.h ('k') | Source/core/html/ClassList.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698