[DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms

net/net.gypi

Index: net/net.gypi
diff --git a/net/net.gypi b/net/net.gypi
index dd96f5e0f67b0a93b737a942acff6ea23e3a8364..e0f10719e25af3fbceeacfa73aad3867fb29734b 100644
--- a/net/net.gypi
+++ b/net/net.gypi
@@ -19,6 +19,8 @@
       'base/completion_callback.h',
       'base/connection_type_histograms.cc',
       'base/connection_type_histograms.h',
+      'base/dafsa/lookup_string.cc',

[eroman, 2015/11/06 23:35:50]

Several problems here:

  (1) Why is this in a subdirectory of base? This could just as easily be
dafsa_lookup_string.h, there is nothing else in that subdirectory (and also not
sure subdirectories of base are a pattern I want to encourage).

  (2) "dafsa" is not a particularly descriptive name. I would be surprised if
many chromium developers could tell you what that meant.

 (3) Unit test?

[Adam Rice, 2015/11/09 11:01:21]

Renamed to base/lookup_string_in_fixed_set.*

Also added unit tests.

+      'base/dafsa/lookup_string.h',
       'base/escape.cc',
       'base/escape.h',
       'base/hash_value.cc',
@@ -1296,6 +1298,7 @@
       'base/sdch_dictionary_unittest.cc',
       'base/sdch_manager_unittest.cc',
       'base/static_cookie_policy_unittest.cc',
+      'base/swr_histogram_domains/swr_histogram_domains_unittest.cc',

[eroman, 2015/11/06 23:35:50]

similar issue here:

  (1) Why in a subdirectory
  (2) swr_* is not a helpful name

[Adam Rice, 2015/11/09 11:01:21]

I was just copying the structure of registry_controlled_domains. It feels
somehow that .gperf files are "special" and deserve their own subdirectory.

I will remove the subdirectory.
I will change it to stale_while_revalidate_experiment_domains.

       'base/test_completion_callback_unittest.cc',
       'base/upload_bytes_element_reader_unittest.cc',
       'base/upload_file_element_reader_unittest.cc',