[DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms

net/net.gypi

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file is shared between the regular GYP build, the NaCl GYP build, and
 # the GN build. For GN support, it must have no conditionals or anything like
 # that beyond the simple one-level-deep dictionary of values.
 {
   'variables': {
     # Subset of net source files that are compiled for NaCl (net_nacl target).
     # These files must not depend on files listed in sources list in the net
     # target.
     'net_nacl_common_sources' : [
       'base/address_family.h',
       'base/address_list.cc',
       'base/address_list.h',
       'base/auth.cc',
       'base/auth.h',
       'base/completion_callback.h',
       'base/connection_type_histograms.cc',
       'base/connection_type_histograms.h',
+      'base/dafsa/lookup_string.cc',

[eroman, 2015/11/06 23:35:50]

Several problems here:

  (1) Why is this in a subdirectory of base? This could just as easily be
dafsa_lookup_string.h, there is nothing else in that subdirectory (and also not
sure subdirectories of base are a pattern I want to encourage).

  (2) "dafsa" is not a particularly descriptive name. I would be surprised if
many chromium developers could tell you what that meant.

 (3) Unit test?

[Adam Rice, 2015/11/09 11:01:21]

Renamed to base/lookup_string_in_fixed_set.*

Also added unit tests.

+      'base/dafsa/lookup_string.h',
       'base/escape.cc',
       'base/escape.h',
       'base/hash_value.cc',
       'base/hash_value.h',
       'base/host_port_pair.cc',
       'base/host_port_pair.h',
       'base/io_buffer.cc',
       'base/io_buffer.h',
       'base/ip_address_number.cc',
       'base/ip_address_number.h',
@@ skipping 1257 matching lines @@
       'base/network_change_notifier_win_unittest.cc',
       'base/network_interfaces_unittest.cc',
       'base/network_quality_estimator_unittest.cc',
       'base/port_util_unittest.cc',
       'base/prioritized_dispatcher_unittest.cc',
       'base/priority_queue_unittest.cc',
       'base/registry_controlled_domains/registry_controlled_domain_unittest.cc',
       'base/sdch_dictionary_unittest.cc',
       'base/sdch_manager_unittest.cc',
       'base/static_cookie_policy_unittest.cc',
+      'base/swr_histogram_domains/swr_histogram_domains_unittest.cc',

[eroman, 2015/11/06 23:35:50]

similar issue here:

  (1) Why in a subdirectory
  (2) swr_* is not a helpful name

[Adam Rice, 2015/11/09 11:01:21]

I was just copying the structure of registry_controlled_domains. It feels
somehow that .gperf files are "special" and deserve their own subdirectory.

I will remove the subdirectory.
I will change it to stale_while_revalidate_experiment_domains.

       'base/test_completion_callback_unittest.cc',
       'base/upload_bytes_element_reader_unittest.cc',
       'base/upload_file_element_reader_unittest.cc',
       'base/url_util_unittest.cc',
       'cert/cert_policy_enforcer_unittest.cc',
       'cert/cert_verify_proc_unittest.cc',
       'cert/cert_verify_proc_whitelist_unittest.cc',
       'cert/crl_set_unittest.cc',
       'cert/ct_log_response_parser_unittest.cc',
       'cert/ct_log_verifier_unittest.cc',
@@ skipping 593 matching lines @@
       'docs/bug-triage.md',
       'docs/bug-triage-labels.md',
       'docs/bug-triage-suggested-workflow.md',
       'docs/code-patterns.md',
       'docs/life-of-a-url-request.md',
       'sdch/README.md',
     ],
     'net_docs_output_dir': '<(PRODUCT_DIR)/net/docs',
   }
 }