Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Unified Diff: net/tools/tld_cleanup/PRESUBMIT.py

Issue 1303973009: [DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to fix patch errors on try bots. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/tools/tld_cleanup/PRESUBMIT.py
diff --git a/net/tools/tld_cleanup/PRESUBMIT.py b/net/tools/tld_cleanup/PRESUBMIT.py
deleted file mode 100644
index 8391e0e61a131b4a218debfef9e285310ee8b697..0000000000000000000000000000000000000000
--- a/net/tools/tld_cleanup/PRESUBMIT.py
+++ /dev/null
@@ -1,32 +0,0 @@
-# Copyright 2014 The Chromium Authors. All rights reserved.
-# Use of this source code is governed by a BSD-style license that can be
-# found in the LICENSE file.
-
-
-"""Chromium presubmit script for src/net/tools/tld_cleanup."""
-
-
-def _RunMakeDafsaTests(input_api, output_api):
- """Runs unittest for make_dafsa if any related file has been modified."""
- files = ('net/tools/tld_cleanup/make_dafsa.py',
- 'net/tools/tld_cleanup/make_dafsa_unittest.py')
- if not any(f in input_api.LocalPaths() for f in files):
- return []
- test_path = input_api.os_path.join(input_api.PresubmitLocalPath(),
- 'make_dafsa_unittest.py')
- cmd_name = 'make_dafsa_unittest'
- cmd = [input_api.python_executable, test_path]
- test_cmd = input_api.Command(
- name=cmd_name,
- cmd=cmd,
- kwargs={},
- message=output_api.PresubmitPromptWarning)
- return input_api.RunTests([test_cmd])
-
-
-def CheckChangeOnUpload(input_api, output_api):
- return _RunMakeDafsaTests(input_api, output_api)
-
-
-def CheckChangeOnCommit(input_api, output_api):
- return _RunMakeDafsaTests(input_api, output_api)

Powered by Google App Engine
This is Rietveld 408576698