[DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms

chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Index: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
diff --git a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
similarity index 55%
copy from chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
copy to chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
index 58eebca22a8fb8b653b330b4a782f9ca3ff8dbc6..adff509c2916de1d91624731266dfd7f83c03695 100644
--- a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.h
+++ b/chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h
@@ -2,16 +2,17 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
-#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
+#ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_
+#define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_
 
 #include "base/macros.h"
 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
+#include "content/public/browser/navigation_handle.h"

[tyoshino (SeeGerritForStatus), 2015/11/04 07:25:12]

can be moved to .cc file (put a forward declaration in this file instead)?

[Adam Rice, 2015/11/05 05:30:39]

Done.

 
-class FromGWSPageLoadMetricsObserver
+class StaleWhileRevalidateMetricsObserver
     : public page_load_metrics::PageLoadMetricsObserver {
  public:
-  explicit FromGWSPageLoadMetricsObserver(
+  explicit StaleWhileRevalidateMetricsObserver(
       page_load_metrics::PageLoadMetricsObservable* metrics);
   // page_load_metrics::PageLoadMetricsObserver implementation:
   void OnCommit(content::NavigationHandle* navigation_handle) override;
@@ -20,16 +21,13 @@ class FromGWSPageLoadMetricsObserver
       const page_load_metrics::PageLoadExtraInfo& extra_info) override;
   void OnPageLoadMetricsGoingAway() override;
 
- protected:
-  // Called in tests.
-  void SetCommittedURLAndReferrer(const GURL& url,
-                                  const content::Referrer& referrer);
-
  private:
-  bool navigation_from_gws_;
+  // True if the committed URL is one of the 100 domains of interest to the

[tyoshino (SeeGerritForStatus), 2015/11/04 07:25:12]

unless you need to emphasis "100" for the readers of this file, we should not
include the detailed number in this file as it's more likely to become stale.

[Adam Rice, 2015/11/05 05:30:39]

Good point, thank you.

+  // stale-while-revalidate experiment.
+  bool is_interesting_domain_;
   page_load_metrics::PageLoadMetricsObservable* const metrics_;
 
-  DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver);
+  DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);
 };
 
-#endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OBSERVER_H_
+#endif  // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRICS_OBSERVER_H_