Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/page_load_metrics/observers/stale_while_revalidate_metrics_observer.h

Issue 1303973009: [DO NOT COMMIT] Re-use the dafsa code for s-w-r histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Correct the build files. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_ 5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS_OB SERVER_H_ 6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_METRIC S_OBSERVER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h" 9 #include "components/page_load_metrics/browser/page_load_metrics_observer.h"
10 #include "content/public/browser/navigation_handle.h"
tyoshino (SeeGerritForStatus) 2015/11/04 07:25:12 can be moved to .cc file (put a forward declaratio
Adam Rice 2015/11/05 05:30:39 Done.
10 11
11 class FromGWSPageLoadMetricsObserver 12 class StaleWhileRevalidateMetricsObserver
12 : public page_load_metrics::PageLoadMetricsObserver { 13 : public page_load_metrics::PageLoadMetricsObserver {
13 public: 14 public:
14 explicit FromGWSPageLoadMetricsObserver( 15 explicit StaleWhileRevalidateMetricsObserver(
15 page_load_metrics::PageLoadMetricsObservable* metrics); 16 page_load_metrics::PageLoadMetricsObservable* metrics);
16 // page_load_metrics::PageLoadMetricsObserver implementation: 17 // page_load_metrics::PageLoadMetricsObserver implementation:
17 void OnCommit(content::NavigationHandle* navigation_handle) override; 18 void OnCommit(content::NavigationHandle* navigation_handle) override;
18 void OnComplete( 19 void OnComplete(
19 const page_load_metrics::PageLoadTiming& timing, 20 const page_load_metrics::PageLoadTiming& timing,
20 const page_load_metrics::PageLoadExtraInfo& extra_info) override; 21 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
21 void OnPageLoadMetricsGoingAway() override; 22 void OnPageLoadMetricsGoingAway() override;
22 23
23 protected:
24 // Called in tests.
25 void SetCommittedURLAndReferrer(const GURL& url,
26 const content::Referrer& referrer);
27
28 private: 24 private:
29 bool navigation_from_gws_; 25 // True if the committed URL is one of the 100 domains of interest to the
tyoshino (SeeGerritForStatus) 2015/11/04 07:25:12 unless you need to emphasis "100" for the readers
Adam Rice 2015/11/05 05:30:39 Good point, thank you.
26 // stale-while-revalidate experiment.
27 bool is_interesting_domain_;
30 page_load_metrics::PageLoadMetricsObservable* const metrics_; 28 page_load_metrics::PageLoadMetricsObservable* const metrics_;
31 29
32 DISALLOW_COPY_AND_ASSIGN(FromGWSPageLoadMetricsObserver); 30 DISALLOW_COPY_AND_ASSIGN(StaleWhileRevalidateMetricsObserver);
33 }; 31 };
34 32
35 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_FROM_GWS_PAGE_LOAD_METRICS _OBSERVER_H_ 33 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_STALE_WHILE_REVALIDATE_MET RICS_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698