Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1303863002: [simd] Introduce SIMD types (as classes) (Closed)

Created:
5 years, 4 months ago by rossberg
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev, bbudge
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd] Introduce SIMD types (as classes) - Introduce a proper bit for SIMD primitive values. - Introduce constructors for individual SIMD types. These are currently just classes, which seems good enough for now, given that we always have exactly one global map per SIMD type. The only problem with using class types for SIMD is that a SIMD constant won't be a subtype of its specific type, only of the general SIMD type. But until we actually introduce SIMD constants into the compiler that shouldn't matter. R=jarin@chromium.org BUG= Committed: https://crrev.com/a60f19220aadbe56bc34d2a4c040e75b2a5833fb Cr-Commit-Position: refs/heads/master@{#30294}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -8 lines) Patch
M src/types.h View 4 chunks +9 lines, -3 lines 0 comments Download
M src/types.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/types-inl.h View 1 chunk +12 lines, -2 lines 0 comments Download
M test/cctest/types-fuzz.h View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
rossberg
5 years, 4 months ago (2015-08-20 14:23:02 UTC) #1
Jarin
lgtm
5 years, 4 months ago (2015-08-20 17:58:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303863002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303863002/1
5 years, 4 months ago (2015-08-21 09:54:13 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 10:49:34 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 10:49:45 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a60f19220aadbe56bc34d2a4c040e75b2a5833fb
Cr-Commit-Position: refs/heads/master@{#30294}

Powered by Google App Engine
This is Rietveld 408576698