src/types.cc - Issue 1303863002: [simd] Introduce SIMD types (as classes)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/types.cc

Issue 1303863002: [simd] Introduce SIMD types (as classes) (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/types.cc

diff --git a/src/types.cc b/src/types.cc

index a904c6eefa7755cf2f10788f93637d9ea2ef86ea..0726bab70cf16e95838b156ed6e3d2ad7ba8ff2b 100644

--- a/src/types.cc

+++ b/src/types.cc

@@ -229,8 +229,7 @@ TypeImpl<Config>::BitsetType::Lub(i::Map* map) {

case HEAP_NUMBER_TYPE:

return kNumber & kTaggedPointer;

case SIMD128_VALUE_TYPE:

- // TODO(bbudge): Add type bits for SIMD value types.

- return kAny;

+ return kSimd;

case JS_VALUE_TYPE:

case JS_DATE_TYPE:

case JS_OBJECT_TYPE:

« no previous file with comments | « src/types.h ('k') | src/types-inl.h » ('j') | no next file with comments »