Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303823002: ServiceWorker: Show a warning when ServiceWorker(Client) attempts to send a transferable ArrayBuffer (Closed)

Created:
5 years, 4 months ago by nhiroki
Modified:
5 years, 4 months ago
Reviewers:
kinuko
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Show a warning when ServiceWorker(Client) attempts to send a transferable ArrayBuffer In the current implementation, ServiceWorker and ServiceWorkerClient do not support sending an ArrayBuffer as a transferable object yet and unexpectedly lose the buffer without any warning. BUG=511119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
nhiroki
PTAL
5 years, 4 months ago (2015-08-20 05:01:43 UTC) #2
kinuko
lgtm
5 years, 4 months ago (2015-08-20 06:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
5 years, 4 months ago (2015-08-20 06:27:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110852)
5 years, 4 months ago (2015-08-20 07:03:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
5 years, 4 months ago (2015-08-20 07:17:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110881)
5 years, 4 months ago (2015-08-20 07:49:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
5 years, 4 months ago (2015-08-20 07:50:52 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 08:15:10 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200883

Powered by Google App Engine
This is Rietveld 408576698