Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1303823002: ServiceWorker: Show a warning when ServiceWorker(Client) attempts to send a transferable ArrayBuffer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by nhiroki
Modified:
2 years, 1 month ago
Reviewers:
kinuko
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Show a warning when ServiceWorker(Client) attempts to send a transferable ArrayBuffer In the current implementation, ServiceWorker and ServiceWorkerClient do not support sending an ArrayBuffer as a transferable object yet and unexpectedly lose the buffer without any warning. BUG=511119 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M Source/modules/serviceworkers/ServiceWorker.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerClient.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
Trybot results:  chromium_presubmit   android_clang_dbg_recipe   android_clang_dbg_recipe   android_clang_dbg_recipe   chromium_presubmit   win_chromium_x64_rel_ng   android_clang_dbg_recipe   chromium_presubmit   android_clang_dbg_recipe   win_chromium_x64_rel_ng   win_chromium_rel_ng   win_chromium_compile_dbg_ng   win8_chromium_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios_rel_device_ninja   ios_dbg_simulator_ninja   linux_chromium_rel_ng   linux_chromium_gn_dbg   linux_chromium_gn_rel   linux_chromium_gn_chromeos_rel   linux_chromium_compile_dbg_32_ng   linux_chromium_clobber_rel_ng   linux_chromium_chromeos_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_chromeos_compile_dbg_ng   linux_chromium_asan_rel_ng   linux_arm_compile   linux_android_rel_ng   chromeos_x86-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_linux   cast_shell_android   android_compile_dbg   android_chromium_gn_compile_rel   android_clang_dbg_recipe   android_chromium_gn_compile_dbg   android_arm64_dbg_recipe   win_chromium_x64_rel_ng   win8_chromium_ng   win_chromium_compile_dbg_ng   win_chromium_rel_ng   mac_chromium_rel_ng   mac_chromium_compile_dbg_ng   ios_rel_device_ninja   ios_dbg_simulator_ninja   linux_chromium_rel_ng   linux_chromium_gn_rel   linux_chromium_compile_dbg_32_ng   linux_chromium_gn_dbg   linux_chromium_gn_chromeos_rel   linux_chromium_chromeos_rel_ng   linux_chromium_clobber_rel_ng   linux_chromium_chromeos_ozone_rel_ng   linux_chromium_asan_rel_ng   linux_chromium_chromeos_compile_dbg_ng   linux_arm_compile   linux_android_rel_ng   chromeos_x86-generic_chromium_compile_only_ng   chromeos_daisy_chromium_compile_only_ng   cast_shell_linux   chromeos_amd64-generic_chromium_compile_only_ng   cast_shell_android   android_clang_dbg_recipe   android_compile_dbg   android_chromium_gn_compile_rel   android_chromium_gn_compile_dbg   android_arm64_dbg_recipe 
Commit queue not available (can’t edit this change).

Messages

Total messages: 14 (6 generated)
nhiroki
PTAL
2 years, 1 month ago (2015-08-20 05:01:43 UTC) #2
kinuko
lgtm
2 years, 1 month ago (2015-08-20 06:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
2 years, 1 month ago (2015-08-20 06:27:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110852)
2 years, 1 month ago (2015-08-20 07:03:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
2 years, 1 month ago (2015-08-20 07:17:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/110881)
2 years, 1 month ago (2015-08-20 07:49:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303823002/1
2 years, 1 month ago (2015-08-20 07:50:52 UTC) #13
commit-bot: I haz the power
2 years, 1 month ago (2015-08-20 08:15:10 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200883
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b