Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303733002: rAc Wallet extirpation, round 2: remove generated card bubble code (Closed)

Created:
5 years, 4 months ago by Evan Stade
Modified:
5 years, 4 months ago
CC:
chromium-reviews, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

rAc Wallet extirpation, round 2: remove generated card bubble code BUG=521733 Committed: https://crrev.com/6c3d31d06f827a21dcf2df1bc1edbdcdc407571c Cr-Commit-Position: refs/heads/master@{#344349}

Patch Set 1 #

Patch Set 2 : one more place #

Patch Set 3 : another reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1639 lines) Patch
M chrome/browser/prefs/browser_prefs.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc View 5 chunks +0 lines, -16 lines 0 comments Download
D chrome/browser/ui/autofill/generated_credit_card_bubble_controller.h View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/ui/autofill/generated_credit_card_bubble_controller.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D chrome/browser/ui/autofill/generated_credit_card_bubble_controller_unittest.cc View 1 chunk +0 lines, -188 lines 0 comments Download
D chrome/browser/ui/autofill/generated_credit_card_bubble_view.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/ui/autofill/generated_credit_card_bubble_view.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.h View 1 chunk +0 lines, -51 lines 0 comments Download
D chrome/browser/ui/autofill/test_generated_credit_card_bubble_controller.cc View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/autofill/test_generated_credit_card_bubble_view.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/ui/autofill/test_generated_credit_card_bubble_view.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.h View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/ui/cocoa/autofill/generated_credit_card_bubble_cocoa.mm View 1 chunk +0 lines, -245 lines 0 comments Download
D chrome/browser/ui/cocoa/location_bar/generated_credit_card_decoration.mm View 1 chunk +0 lines, -61 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.h View 4 chunks +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 6 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/location_bar/location_bar.h View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/views/autofill/generated_credit_card_bubble_views.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D chrome/browser/ui/views/location_bar/generated_credit_card_view.h View 1 chunk +0 lines, -50 lines 0 comments Download
D chrome/browser/ui/views/location_bar/generated_credit_card_view.cc View 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.h View 4 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 8 chunks +0 lines, -21 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 5 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Evan Stade
+sky for OWNERS of *location_bar* +groby for OWNERS of chrome/browser/ui/cocoa/* +dbeam for the rest (ui/autofill ...
5 years, 4 months ago (2015-08-19 17:09:20 UTC) #1
Evan Stade
let's try that again +sky for OWNERS of *location_bar* +groby for OWNERS of chrome/browser/ui/cocoa/* +dbeam ...
5 years, 4 months ago (2015-08-19 17:09:54 UTC) #3
Dan Beam
lgtm++
5 years, 4 months ago (2015-08-19 17:21:44 UTC) #4
sky
LGTM
5 years, 4 months ago (2015-08-19 19:59:02 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303733002/40001
5 years, 4 months ago (2015-08-19 20:24:37 UTC) #7
groby-ooo-7-16
FWIW LGTM as well :)
5 years, 4 months ago (2015-08-19 21:12:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303733002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303733002/40001
5 years, 4 months ago (2015-08-19 21:32:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-19 22:16:05 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:16:48 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/6c3d31d06f827a21dcf2df1bc1edbdcdc407571c
Cr-Commit-Position: refs/heads/master@{#344349}

Powered by Google App Engine
This is Rietveld 408576698