Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303703004: Add more components_unittests to GN build (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, jam, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, plaree+watch_chromium.org, wifiprefetch-reviews_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests4
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more components_unittests to GN build This adds tests for: url matcher, precache, sync driver, serialization, proxy config, leveldb proto, error page, storage monitor, search provider logos, translate, json schema, guest view, dom distiller, network hints. CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel Committed: https://crrev.com/c76a816074e6504b0b4b3420529928057d11b50b Cr-Commit-Position: refs/heads/master@{#344974}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : chromeos, mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+306 lines, -71 lines) Patch
M BUILD.gn View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chromeos/BUILD.gn View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M components/BUILD.gn View 1 2 7 chunks +21 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/content/BUILD.gn View 1 chunk +57 lines, -45 lines 0 comments Download
M components/dom_distiller/core/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/error_page/renderer/BUILD.gn View 2 chunks +12 lines, -1 line 0 comments Download
M components/guest_view/browser/BUILD.gn View 1 chunk +12 lines, -1 line 0 comments Download
M components/json_schema/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments Download
M components/leveldb_proto/BUILD.gn View 1 chunk +13 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M components/network_hints/renderer/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/precache/content/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M components/precache/core/BUILD.gn View 2 chunks +16 lines, -1 line 0 comments Download
M components/proxy_config/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/search_provider_logos/BUILD.gn View 2 chunks +19 lines, -3 lines 0 comments Download
M components/storage_monitor/BUILD.gn View 1 2 3 4 3 chunks +33 lines, -5 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +15 lines, -0 lines 0 comments Download
M components/translate/core/common/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/translate/core/language_detection/BUILD.gn View 2 chunks +16 lines, -4 lines 0 comments Download
M components/url_matcher/BUILD.gn View 1 2 2 chunks +16 lines, -1 line 0 comments Download

Dependent Patchsets:

Issue 1303013005 Patch 1

Messages

Total messages: 29 (14 generated)
brettw
5 years, 4 months ago (2015-08-20 20:08:26 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/20001
5 years, 4 months ago (2015-08-20 20:10:17 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/71866)
5 years, 4 months ago (2015-08-20 20:40:34 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/40001
5 years, 4 months ago (2015-08-20 20:54:55 UTC) #10
Dirk Pranke
lgtm. Take a look at the mac GN failure and see if it's a flake ...
5 years, 4 months ago (2015-08-20 21:29:05 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/71903)
5 years, 4 months ago (2015-08-20 21:30:37 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/60001
5 years, 4 months ago (2015-08-20 21:40:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/80001
5 years, 4 months ago (2015-08-20 23:21:12 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/93607)
5 years, 4 months ago (2015-08-21 01:31:48 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/80001
5 years, 4 months ago (2015-08-21 04:33:43 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/93750)
5 years, 4 months ago (2015-08-21 06:46:06 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303703004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303703004/80001
5 years, 4 months ago (2015-08-22 05:37:30 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 4 months ago (2015-08-22 06:37:39 UTC) #27
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/c76a816074e6504b0b4b3420529928057d11b50b Cr-Commit-Position: refs/heads/master@{#344974}
5 years, 4 months ago (2015-08-22 06:38:20 UTC) #28
yosin_UTC9
5 years, 4 months ago (2015-08-22 12:05:04 UTC) #29
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1313463002/ by yosin@chromium.org.

The reason for reverting is: Compilation error in
storage_monitor_win_unittest.cc.

GYP build may not compile this file.

FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj.rsp
/c ../../components/storage_monitor/storage_monitor_win_unittest.cc
/Foobj/components/storage_monitor/unit_tests/storage_monitor_win_unittest.obj
/Fdobj/components/storage_monitor/unit_tests_cc.pdb
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218)
: error C2220: warning treated as error - no 'object' file generated
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(218)
: warning C4267: '=' : conversion from 'size_t' to 'DWORD', possible loss of
data
e:\b\build\slave\win_x64_gn__dbg_\build\src\components\storage_monitor\storage_monitor_win_unittest.cc(298)
: warning C4267: 'initializing' : conversion from 'size_t' to 'int', possible
loss of data
ninja: build stopped: subcommand failed.
.

Powered by Google App Engine
This is Rietveld 408576698