Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1303013005: Add more components tests to GN build. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, jam, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more components tests to GN build. visitedlink, query_parser, web_cache, autofill CQ_EXTRA_TRYBOTS=tryserver.chromium.mac:mac_chromium_gn_rel TBR=-dpranke@chromium.org Committed: https://crrev.com/0eb6b59c463a0aa9dd01956b5542b8cf158e835a Cr-Commit-Position: refs/heads/master@{#344993}

Patch Set 1 #

Patch Set 2 : \ #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -40 lines) Patch
M components/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
M components/autofill/content/browser/BUILD.gn View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M components/query_parser/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/visitedlink/browser/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/visitedlink/common/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/visitedlink/renderer/BUILD.gn View 1 1 chunk +13 lines, -14 lines 0 comments Download
A + components/visitedlink/test/BUILD.gn View 1 chunk +4 lines, -16 lines 0 comments Download
M components/web_cache/browser/BUILD.gn View 1 2 2 chunks +14 lines, -2 lines 0 comments Download
M components/web_cache/common/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download
M components/web_cache/renderer/BUILD.gn View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
5 years, 4 months ago (2015-08-22 20:52:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303013005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303013005/20001
5 years, 4 months ago (2015-08-22 20:52:13 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/124948)
5 years, 4 months ago (2015-08-22 21:34:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303013005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303013005/40001
5 years, 4 months ago (2015-08-22 23:07:56 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-22 23:36:58 UTC) #9
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0eb6b59c463a0aa9dd01956b5542b8cf158e835a Cr-Commit-Position: refs/heads/master@{#344993}
5 years, 4 months ago (2015-08-22 23:37:29 UTC) #10
tommi (sloooow) - chröme
5 years, 4 months ago (2015-08-23 08:37:04 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1308763004/ by tommi@chromium.org.

The reason for reverting is: Breaks compile on the Win GN bot:

http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20x64%20GN%2...

http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/...

.

Powered by Google App Engine
This is Rietveld 408576698