Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1303493003: Fix inttypes format macros in src/processor/proc_maps_linux.cc (Closed)

Created:
5 years, 4 months ago by Primiano Tucci (use gerrit)
Modified:
5 years, 4 months ago
CC:
google-breakpad-dev_googlegroups.com, Ted Mielczarek, ivanpe
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix inttypes format macros in src/processor/proc_maps_linux.cc crrev.com/1298443002 has introduced a build failure by re-defining __STDC_FORMAT_MACROS. Fixing it. BUG= R=mark@chromium.org, ted.mielczarek@gmail.com Committed: https://code.google.com/p/google-breakpad/source/detail?r=1493

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move up #

Patch Set 3 : move inttypes back in place #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/processor/proc_maps_linux.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
Primiano Tucci (use gerrit)
Mark, not sure what is the right thing to do here. crrev.com/1298443002 broke the build ...
5 years, 4 months ago (2015-08-18 13:35:12 UTC) #2
Ted Mielczarek
This LGTM. Sorry, I don't know much about the Chrome build environment and this builds ...
5 years, 4 months ago (2015-08-18 13:39:05 UTC) #4
Mark Mentovai
https://codereview.chromium.org/1303493003/diff/1/src/processor/proc_maps_linux.cc File src/processor/proc_maps_linux.cc (right): https://codereview.chromium.org/1303493003/diff/1/src/processor/proc_maps_linux.cc#newcode9 src/processor/proc_maps_linux.cc:9: #define __STDC_FORMAT_MACROS 1 It’d be best if this were ...
5 years, 4 months ago (2015-08-18 13:58:10 UTC) #5
Primiano Tucci (use gerrit)
https://codereview.chromium.org/1303493003/diff/1/src/processor/proc_maps_linux.cc File src/processor/proc_maps_linux.cc (right): https://codereview.chromium.org/1303493003/diff/1/src/processor/proc_maps_linux.cc#newcode9 src/processor/proc_maps_linux.cc:9: #define __STDC_FORMAT_MACROS 1 On 2015/08/18 13:58:10, Mark Mentovai - ...
5 years, 4 months ago (2015-08-18 18:53:38 UTC) #6
Mark Mentovai
LGTM, although you could have left <inttypes.h> in the normal place too.
5 years, 4 months ago (2015-08-18 19:25:04 UTC) #7
Primiano Tucci (use gerrit)
On 2015/08/18 19:25:04, Mark Mentovai - out til August wrote: > LGTM, although you could ...
5 years, 4 months ago (2015-08-19 07:24:08 UTC) #8
Primiano Tucci (use gerrit)
5 years, 4 months ago (2015-08-19 07:24:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 1493 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698