Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/processor/proc_maps_linux.cc

Issue 1303493003: Fix inttypes format macros in src/processor/proc_maps_linux.cc (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "google_breakpad/processor/proc_maps_linux.h" 5 #include "google_breakpad/processor/proc_maps_linux.h"
6 6
7 #include <fcntl.h> 7 #include <fcntl.h>
8 #ifndef __STDC_FORMAT_MACROS
8 #define __STDC_FORMAT_MACROS 1 9 #define __STDC_FORMAT_MACROS 1
Mark Mentovai 2015/08/18 13:58:10 It’d be best if this were moved before any #includ
Primiano Tucci (use gerrit) 2015/08/18 18:53:38 Right. Done
10 #endif
9 #include <inttypes.h> 11 #include <inttypes.h>
10 #include <stdio.h> 12 #include <stdio.h>
11 13
12 #include "processor/logging.h" 14 #include "processor/logging.h"
13 15
14 #if defined(OS_ANDROID) && !defined(__LP64__) 16 #if defined(OS_ANDROID) && !defined(__LP64__)
15 // In 32-bit mode, Bionic's inttypes.h defines PRI/SCNxPTR as an 17 // In 32-bit mode, Bionic's inttypes.h defines PRI/SCNxPTR as an
16 // unsigned long int, which is incompatible with Bionic's stdint.h 18 // unsigned long int, which is incompatible with Bionic's stdint.h
17 // defining uintptr_t as an unsigned int: 19 // defining uintptr_t as an unsigned int:
18 // https://code.google.com/p/android/issues/detail?id=57218 20 // https://code.google.com/p/android/issues/detail?id=57218
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 regions.push_back(region); 95 regions.push_back(region);
94 regions.back().path.assign(line + path_index); 96 regions.back().path.assign(line + path_index);
95 regions.back().line.assign(line); 97 regions.back().line.assign(line);
96 } 98 }
97 99
98 regions_out->swap(regions); 100 regions_out->swap(regions);
99 return true; 101 return true;
100 } 102 }
101 103
102 } // namespace google_breakpad 104 } // namespace google_breakpad
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698