Make UrlRequestContextBuilder take scoped_ptr's

Make UrlRequestContextBuilder take scoped_ptr's when it takes ownership

UrlRequestContextBuilder was already taking ownership in most cases, so
it should be taking scoped_ptr's instead of raw pointers.  This change
should help enforce proper ownership and has already identified two
ownership bugs.  I'm fixing the ownership bugs (a double-free of
ProxyConfigService in Cronet and of NetLog in AwURLRequestContextGetter)
in this change also.  I'm changing UrlRequestContextBuilder to not take
ownership of NetLog however as this conflicts with some other uses of
NetLog, like how it's exposed via ContentBrowserClient.

BUG=508553
TBR=jam

Committed: https://crrev.com/53197db553fa979bcdce9836f7346fa898d416fe
Cr-Commit-Position: refs/heads/master@{#346637}

[pauljensen, 2015-08-20 15:24:23]

pauljensen@chromium.org changed reviewers:
+ mmenke@chromium.org

[pauljensen, 2015-08-20 15:24:24]

Matt, PTAL.  If you're too busy I could pick another reviewer; I selected you as
you commented on the related bug.

[mmenke, 2015-08-20 15:51:07]

LGTM.  I am busy this week, but this is a pretty fast CL to review.

Thanks so much for doing this!

https://codereview.chromium.org/1303493002/diff/80001/device/test/usb_test_ga...
File device/test/usb_test_gadget_impl.cc (left):

https://codereview.chromium.org/1303493002/diff/80001/device/test/usb_test_ga...
device/test/usb_test_gadget_impl.cc:146: return context_builder_.Build();
Erm...Wow.

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
File net/url_request/url_request_context_builder.cc (right):

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
net/url_request/url_request_context_builder.cc:268: if (net_log_) {
Again, suggest a short comment about this.

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
net/url_request/url_request_context_builder.h:133: void set_net_log(NetLog*
net_log) { net_log_ = net_log; }
Maybe an extra comment, just for emphasis.

"Unlike the other setters, the builder does not take ownership of the NetLog."

[pauljensen, 2015-08-20 21:45:14]

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
File net/url_request/url_request_context_builder.cc (right):

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
net/url_request/url_request_context_builder.cc:268: if (net_log_) {
On 2015/08/20 15:51:07, mmenke wrote:
> Again, suggest a short comment about this.

Done.

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
File net/url_request/url_request_context_builder.h (right):

https://codereview.chromium.org/1303493002/diff/80001/net/url_request/url_req...
net/url_request/url_request_context_builder.h:133: void set_net_log(NetLog*
net_log) { net_log_ = net_log; }
On 2015/08/20 15:51:07, mmenke wrote:
> Maybe an extra comment, just for emphasis.
> 
> "Unlike the other setters, the builder does not take ownership of the NetLog."

Done.

[pauljensen, 2015-08-20 21:49:27]

pauljensen@chromium.org changed reviewers:
+ ben@chromium.org

[pauljensen, 2015-08-20 21:49:27]

Ben, PTAL.  This is largely a refactoring to simply pass scoped_ptr's in cases
where ownership is transferred.  Matt has thoroughly reviewed the change as a
whole, but I need OWNERS approval for the non-net/ files.

[pauljensen, 2015-08-27 15:09:35]

Ben, it's been a week, ping!

[pauljensen, 2015-08-31 14:15:10]

pauljensen@chromium.org changed reviewers:
+ jam@chromium.org
- ben@chromium.org

[pauljensen, 2015-08-31 14:15:11]

-ben (who I assume doesn't have time to approve)
+jam
John, PTAL.  This is largely a refactoring to simply pass scoped_ptr's in cases
where ownership is transferred.  Matt has thoroughly reviewed the change as a
whole, but I need OWNERS approval for the non-net/ files.

[jam, 2015-08-31 20:09:53]

On 2015/08/31 14:15:11, pauljensen wrote:
> -ben (who I assume doesn't have time to approve)
> +jam
> John, PTAL.  This is largely a refactoring to simply pass scoped_ptr's in
cases
> where ownership is transferred.  Matt has thoroughly reviewed the change as a
> whole, but I need OWNERS approval for the non-net/ files.

per
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...,
you only need owner approval for the api change. for changing consumers, you can
TBR owners there

[pauljensen, 2015-09-01 11:45:06]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2015-09-01 11:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1303493002/#ps100001
(title: "add two small comments")

[commit-bot: I haz the power, 2015-09-01 11:45:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303493002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303493002/100001

[commit-bot: I haz the power, 2015-09-01 11:56:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 11:56:54]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pauljensen, 2015-09-01 12:15:15]

The CQ bit was checked by pauljensen@chromium.org

[pauljensen, 2015-09-01 12:15:15]

The patchset sent to the CQ was uploaded after l-g-t-m from mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/1303493002/#ps120001
(title: "sync and fix tiny resulting build failure")

[commit-bot: I haz the power, 2015-09-01 12:15:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303493002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303493002/120001

[commit-bot: I haz the power, 2015-09-01 13:19:53]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-09-01 13:20:31]

Patchset 7 (id:??) landed as
https://crrev.com/53197db553fa979bcdce9836f7346fa898d416fe
Cr-Commit-Position: refs/heads/master@{#346637}