|
Make UrlRequestContextBuilder take scoped_ptr's when it takes ownership
UrlRequestContextBuilder was already taking ownership in most cases, so
it should be taking scoped_ptr's instead of raw pointers. This change
should help enforce proper ownership and has already identified two
ownership bugs. I'm fixing the ownership bugs (a double-free of
ProxyConfigService in Cronet and of NetLog in AwURLRequestContextGetter)
in this change also. I'm changing UrlRequestContextBuilder to not take
ownership of NetLog however as this conflicts with some other uses of
NetLog, like how it's exposed via ContentBrowserClient.
BUG= 508553
TBR=jam
Committed: https://crrev.com/53197db553fa979bcdce9836f7346fa898d416fe
Cr-Commit-Position: refs/heads/master@{#346637}
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+83 lines, -73 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
android_webview/browser/net/aw_url_request_context_getter.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+9 lines, -8 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/service/net/service_url_request_context_getter.cc
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chrome/test/chromedriver/net/url_request_context_getter.cc
|
View
|
1
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
chromecast/net/connectivity_checker_impl.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
cloud_print/gcp20/prototype/cloud_print_url_request_context_getter.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/cronet/android/cronet_url_request_context_adapter.h
|
View
|
1
2
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/cronet/android/cronet_url_request_context_adapter.cc
|
View
|
1
2
3
4
5
6
|
3 chunks |
+10 lines, -14 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/cronet/android/url_request_context_adapter.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc
|
View
|
1
2
3
4
5
6
|
1 chunk |
+3 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
device/test/usb_test_gadget_impl.cc
|
View
|
1
2
3
4
5
6
|
2 chunks |
+8 lines, -3 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
mojo/services/network/network_context.cc
|
View
|
1
|
2 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/tools/get_server_time/get_server_time.cc
|
View
|
1
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/url_request/url_request_context_builder.h
|
View
|
1
2
3
4
5
6
|
4 chunks |
+14 lines, -13 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/url_request/url_request_context_builder.cc
|
View
|
1
2
3
4
5
6
|
7 chunks |
+11 lines, -10 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
net/url_request/url_request_context_builder_unittest.cc
|
View
|
1
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
remoting/base/url_request_context_getter.h
|
View
|
1
2
3
|
2 chunks |
+2 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
remoting/base/url_request_context_getter.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
Total messages: 20 (8 generated)
|