chromecast/net/connectivity_checker_impl.cc - Issue 1303493002: Make UrlRequestContextBuilder take scoped_ptr's

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/net/connectivity_checker_impl.cc

Issue 1303493002: Make UrlRequestContextBuilder take scoped_ptr's (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync and fix tiny resulting build failure Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/net/connectivity_checker_impl.cc

diff --git a/chromecast/net/connectivity_checker_impl.cc b/chromecast/net/connectivity_checker_impl.cc

index 0ab09daf96f60d8d480f61271581c56fe92377c9..9a2b14b21ec8f8f3b6064971128fd736adadeb44 100644

--- a/chromecast/net/connectivity_checker_impl.cc

+++ b/chromecast/net/connectivity_checker_impl.cc

@@ -57,10 +57,10 @@ void ConnectivityCheckerImpl::Initialize() {

check_url_str.empty() ? kDefaultConnectivityCheckUrl : check_url_str));

net::URLRequestContextBuilder builder;

- builder.set_proxy_config_service(

- new net::ProxyConfigServiceFixed(net::ProxyConfig::CreateDirect()));

+ builder.set_proxy_config_service(make_scoped_ptr(

+ new net::ProxyConfigServiceFixed(net::ProxyConfig::CreateDirect())));

builder.DisableHttpCache();

- url_request_context_.reset(builder.Build());

+ url_request_context_ = builder.Build().Pass();

net::NetworkChangeNotifier::AddNetworkChangeObserver(this);

task_runner_->PostTask(FROM_HERE,