Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 1303403004: [Interpreter] Add support for parameter variables. (Closed)

Created:
5 years, 4 months ago by rmcilroy
Modified:
5 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, oth
Base URL:
https://chromium.googlesource.com/v8/v8.git@int_add_bytecodes
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[Interpreter] Add support for parameter variables. Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator. Parameters are accessed as negative interpreter registers. BUG=v8:4280 LOG=N Committed: https://crrev.com/5d975694e4d3ecf66716cc5395d4d10c9730f9dd Cr-Commit-Position: refs/heads/master@{#30403}

Patch Set 1 : #

Patch Set 2 : Fix Windows build #

Total comments: 6

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -88 lines) Patch
M src/arm/builtins-arm.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/factory.h View 1 chunk +1 line, -1 line 0 comments Download
M src/factory.cc View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M src/frames.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/heap/heap.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M src/interpreter/bytecode-array-builder.h View 5 chunks +15 lines, -1 line 0 comments Download
M src/interpreter/bytecode-array-builder.cc View 3 chunks +24 lines, -4 lines 0 comments Download
M src/interpreter/bytecode-generator.cc View 1 2 3 chunks +8 lines, -3 lines 0 comments Download
M src/mips/builtins-mips.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/objects.h View 1 2 2 chunks +8 lines, -3 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M test/cctest/interpreter/test-bytecode-generator.cc View 9 chunks +54 lines, -12 lines 0 comments Download
M test/cctest/interpreter/test-interpreter.cc View 1 9 chunks +139 lines, -39 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M test/unittests/interpreter/bytecode-array-builder-unittest.cc View 4 chunks +14 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 42 (24 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/1
5 years, 4 months ago (2015-08-24 23:46:40 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/40001
5 years, 4 months ago (2015-08-25 00:02:23 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/3606)
5 years, 4 months ago (2015-08-25 00:10:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/80001
5 years, 4 months ago (2015-08-25 11:12:44 UTC) #12
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-25 11:12:46 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/80001
5 years, 4 months ago (2015-08-25 11:15:24 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/7296) v8_linux_arm_rel on ...
5 years, 4 months ago (2015-08-25 11:16:16 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/120001
5 years, 4 months ago (2015-08-25 11:32:51 UTC) #22
rmcilroy
Michael, could you take a look please, thanks.
5 years, 4 months ago (2015-08-25 11:37:35 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compile_rel/builds/4137)
5 years, 4 months ago (2015-08-25 11:39:03 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/140001
5 years, 3 months ago (2015-08-25 14:54:52 UTC) #28
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-25 15:20:30 UTC) #30
Michael Starzinger
LGTM. https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc#newcode1032 src/arm64/builtins-arm64.cc:1032: __ Drop(x1); Not sure but isn't the ARM64 ...
5 years, 3 months ago (2015-08-26 13:44:36 UTC) #31
rmcilroy
https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm64.cc#newcode1032 src/arm64/builtins-arm64.cc:1032: __ Drop(x1); On 2015/08/26 13:44:36, Michael Starzinger wrote: > ...
5 years, 3 months ago (2015-08-27 09:54:39 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/160001
5 years, 3 months ago (2015-08-27 09:56:13 UTC) #35
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303403004/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303403004/180001
5 years, 3 months ago (2015-08-27 09:57:43 UTC) #40
commit-bot: I haz the power
Committed patchset #3 (id:180001)
5 years, 3 months ago (2015-08-27 10:32:32 UTC) #41
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 10:32:50 UTC) #42
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d975694e4d3ecf66716cc5395d4d10c9730f9dd
Cr-Commit-Position: refs/heads/master@{#30403}

Powered by Google App Engine
This is Rietveld 408576698