[Interpreter] Add support for parameter variables.

[Interpreter] Add support for parameter variables.

Adds support for parameters to the BytecodeArrayBuilder and BytecodeGenerator.
Parameters are accessed as negative interpreter registers.

BUG=v8:4280
LOG=N

Committed: https://crrev.com/5d975694e4d3ecf66716cc5395d4d10c9730f9dd
Cr-Commit-Position: refs/heads/master@{#30403}

[rmcilroy, 2015-08-24 23:46:28]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-24 23:46:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/1

[rmcilroy, 2015-08-25 00:01:55]

Patchset #1 (id:1) has been deleted

[rmcilroy, 2015-08-25 00:02:13]

Patchset #1 (id:20001) has been deleted

[rmcilroy, 2015-08-25 00:02:18]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-25 00:02:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/40001

[commit-bot: I haz the power, 2015-08-25 00:10:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 00:10:55]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/...)

[rmcilroy, 2015-08-25 11:12:34]

Patchset #1 (id:40001) has been deleted

[rmcilroy, 2015-08-25 11:12:38]

Patchset #1 (id:60001) has been deleted

[rmcilroy, 2015-08-25 11:12:41]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-08-25 11:12:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/80001

[commit-bot: I haz the power, 2015-08-25 11:12:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 11:12:46]

No L-G-T-M from a valid reviewer yet. Only full committers are accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[rmcilroy, 2015-08-25 11:15:18]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-25 11:15:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/80001

[commit-bot: I haz the power, 2015-08-25 11:16:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 11:16:16]

Dry run: Try jobs failed on following builders:
  v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/...)
  v8_linux_arm_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/7356)
  v8_linux_dbg on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/7970)
  v8_linux_gcc_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel/builds/8906)
  v8_mac_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/9029)
  v8_presubmit on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/5190)

[rmcilroy, 2015-08-25 11:19:01]

Patchset #1 (id:80001) has been deleted

[rmcilroy, 2015-08-25 11:32:32]

Patchset #1 (id:100001) has been deleted

[rmcilroy, 2015-08-25 11:32:39]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-25 11:32:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/120001

[rmcilroy, 2015-08-25 11:37:34]

rmcilroy@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[rmcilroy, 2015-08-25 11:37:35]

Michael, could you take a look please, thanks.

[commit-bot: I haz the power, 2015-08-25 11:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 11:39:03]

Dry run: Try jobs failed on following builders:
  v8_win_nosnap_shared_compile_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_compil...)

[rmcilroy, 2015-08-25 14:54:43]

The CQ bit was checked by rmcilroy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-25 14:54:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/140001

[commit-bot: I haz the power, 2015-08-25 15:20:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 15:20:30]

Dry run: This issue passed the CQ dry run.

[Michael Starzinger, 2015-08-26 13:44:36]

LGTM.

https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm...
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm...
src/arm64/builtins-arm64.cc:1032: __ Drop(x1);
Not sure but isn't the ARM64 macro assembler expecting "count" instead of size
here when a register is passed in? Shouldn't this be "Drop(x1, 1)" instead?

https://codereview.chromium.org/1303403004/diff/140001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1303403004/diff/140001/src/frames.h#newcode183
src/frames.h:183: 
nit: Two empty newlines.

https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h#newc...
src/objects-inl.h:4063: return READ_INT_FIELD(this, kParameterSizeOffset) >>
kPointerSizeLog2;
Can we leave a short one-liner comment here that the "count" is stored as a
"size" so that generated code can use it directly?

Also is this "trick" really worth it? Don't most of the architectures should
have instructions with the appropriate scalling factors? Not an expert on this,
so I don't mind either way.

[rmcilroy, 2015-08-27 09:54:39]

https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm...
File src/arm64/builtins-arm64.cc (right):

https://codereview.chromium.org/1303403004/diff/140001/src/arm64/builtins-arm...
src/arm64/builtins-arm64.cc:1032: __ Drop(x1);
On 2015/08/26 13:44:36, Michael Starzinger wrote:
> Not sure but isn't the ARM64 macro assembler expecting "count" instead of size
> here when a register is passed in? Shouldn't this be "Drop(x1, 1)" instead?

Yes, good catch thanks!

https://codereview.chromium.org/1303403004/diff/140001/src/frames.h
File src/frames.h (right):

https://codereview.chromium.org/1303403004/diff/140001/src/frames.h#newcode183
src/frames.h:183: 
On 2015/08/26 13:44:36, Michael Starzinger wrote:
> nit: Two empty newlines.

Done.

https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h
File src/objects-inl.h (right):

https://codereview.chromium.org/1303403004/diff/140001/src/objects-inl.h#newc...
src/objects-inl.h:4063: return READ_INT_FIELD(this, kParameterSizeOffset) >>
kPointerSizeLog2;
On 2015/08/26 13:44:36, Michael Starzinger wrote:
> Can we leave a short one-liner comment here that the "count" is stored as a
> "size" so that generated code can use it directly?

Done.

> Also is this "trick" really worth it? Don't most of the architectures should
> have instructions with the appropriate scalling factors? Not an expert on
this,
> so I don't mind either way.

I don't think they are always available AFAIKT. E.g., on Arm you can scale and
immediate add or scale the offset for an ldr, but you can't scale a reg+reg add
or the result of an ldr which is what would be needed here.

[rmcilroy, 2015-08-27 09:56:05]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-27 09:56:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1303403004/#ps160001
(title: "Address review comments.")

[commit-bot: I haz the power, 2015-08-27 09:56:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/160001

[rmcilroy, 2015-08-27 09:56:24]

The CQ bit was unchecked by rmcilroy@chromium.org

[rmcilroy, 2015-08-27 09:57:26]

Patchset #3 (id:160001) has been deleted

[rmcilroy, 2015-08-27 09:57:32]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2015-08-27 09:57:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1303403004/#ps180001
(title: "Address review comments")

[commit-bot: I haz the power, 2015-08-27 09:57:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303403004/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303403004/180001

[commit-bot: I haz the power, 2015-08-27 10:32:32]

Committed patchset #3 (id:180001)

[commit-bot: I haz the power, 2015-08-27 10:32:50]

Patchset 3 (id:??) landed as
https://crrev.com/5d975694e4d3ecf66716cc5395d4d10c9730f9dd
Cr-Commit-Position: refs/heads/master@{#30403}