Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 1303403004: [Interpreter] Add support for parameter variables. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_add_bytecodes
Patch Set: Address review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 734 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 // TODO(rmcilroy): List of things not currently dealt with here but done in 745 // TODO(rmcilroy): List of things not currently dealt with here but done in
746 // fullcodegen's EmitReturnSequence. 746 // fullcodegen's EmitReturnSequence.
747 // - Supporting FLAG_trace for Runtime::TraceExit. 747 // - Supporting FLAG_trace for Runtime::TraceExit.
748 // - Support profiler (specifically decrementing profiling_counter 748 // - Support profiler (specifically decrementing profiling_counter
749 // appropriately and calling out to HandleInterrupts if necessary). 749 // appropriately and calling out to HandleInterrupts if necessary).
750 750
751 // The return value is in accumulator, which is already in rax. 751 // The return value is in accumulator, which is already in rax.
752 752
753 // Leave the frame (also dropping the register file). 753 // Leave the frame (also dropping the register file).
754 __ leave(); 754 __ leave();
755 // Return droping receiver + arguments. 755
756 // TODO(rmcilroy): Get number of arguments from BytecodeArray. 756 // Drop receiver + arguments and return.
757 __ Ret(1 * kPointerSize, ecx); 757 __ mov(ebx, FieldOperand(kInterpreterBytecodeArrayRegister,
758 BytecodeArray::kParameterSizeOffset));
759 __ pop(ecx);
760 __ add(esp, ebx);
761 __ push(ecx);
762 __ ret(0);
758 } 763 }
759 764
760 765
761 void Builtins::Generate_CompileLazy(MacroAssembler* masm) { 766 void Builtins::Generate_CompileLazy(MacroAssembler* masm) {
762 CallRuntimePassFunction(masm, Runtime::kCompileLazy); 767 CallRuntimePassFunction(masm, Runtime::kCompileLazy);
763 GenerateTailCallToReturnedCode(masm); 768 GenerateTailCallToReturnedCode(masm);
764 } 769 }
765 770
766 771
767 772
(...skipping 1014 matching lines...) Expand 10 before | Expand all | Expand 10 after
1782 1787
1783 __ bind(&ok); 1788 __ bind(&ok);
1784 __ ret(0); 1789 __ ret(0);
1785 } 1790 }
1786 1791
1787 #undef __ 1792 #undef __
1788 } // namespace internal 1793 } // namespace internal
1789 } // namespace v8 1794 } // namespace v8
1790 1795
1791 #endif // V8_TARGET_ARCH_IA32 1796 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/heap/heap.cc ('k') | src/interpreter/bytecode-array-builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698