Fix WebGL2 GetFramebufferAttachmentParameteriv.

Fix WebGL2 GetFramebufferAttachmentParameteriv.

command buffer side CL: https://codereview.chromium.org/1319453010/

BUG=527249
TEST=conformance2/state/gl-object-get-calls.html related parts pass
R=kbr@chromium.org,bajones@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201822

[Zhenyao Mo, 2015-09-04 00:20:52]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-04 00:20:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303343009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303343009/1

[Zhenyao Mo, 2015-09-04 00:20:58]

PTAL

[Ken Russell (switch to Gerrit), 2015-09-04 00:51:18]

Excellent. LGTM

https://codereview.chromium.org/1303343009/diff/1/Source/modules/webgl/WebGL2...
File Source/modules/webgl/WebGL2RenderingContextBase.cpp (right):

https://codereview.chromium.org/1303343009/diff/1/Source/modules/webgl/WebGL2...
Source/modules/webgl/WebGL2RenderingContextBase.cpp:2355:
synthesizeGLError(GL_INVALID_ENUM, kFunctionName, "invalid parameter name");
Is it specified that querying GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME for the
default framebuffer's attachments (BACK, DEPTH, STENCIL) is supposed to generate
an INVALID_ENUM error? Is that the "fall-through" case in the spec ("Any
combinations of framebuffer type and pname not described above...")?

[commit-bot: I haz the power, 2015-09-04 01:23:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-04 01:23:25]

Dry run: This issue passed the CQ dry run.

[bajones, 2015-09-04 17:42:40]

LGTM, too!

[Zhenyao Mo, 2015-09-04 20:44:54]

https://codereview.chromium.org/1303343009/diff/1/Source/modules/webgl/WebGL2...
File Source/modules/webgl/WebGL2RenderingContextBase.cpp (right):

https://codereview.chromium.org/1303343009/diff/1/Source/modules/webgl/WebGL2...
Source/modules/webgl/WebGL2RenderingContextBase.cpp:2355:
synthesizeGLError(GL_INVALID_ENUM, kFunctionName, "invalid parameter name");
On 2015/09/04 00:51:18, Ken Russell wrote:
> Is it specified that querying GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME for the
> default framebuffer's attachments (BACK, DEPTH, STENCIL) is supposed to
generate
> an INVALID_ENUM error? Is that the "fall-through" case in the spec ("Any
> combinations of framebuffer type and pname not described above...")?

Yes, that's how I interpret the spec.

[Zhenyao Mo, 2015-09-04 20:44:59]

The CQ bit was checked by zmo@chromium.org

[commit-bot: I haz the power, 2015-09-04 20:45:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303343009/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303343009/1

[commit-bot: I haz the power, 2015-09-04 20:49:49]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201822