Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 1303343009: Fix WebGL2 GetFramebufferAttachmentParameteriv.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 1303343009: Fix WebGL2 GetFramebufferAttachmentParameteriv. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/Source/modules/webgl/WebGLRenderingContextBase.cpp b/Source/modules/webgl/WebGLRenderingContextBase.cpp

index a9ede5ea3e1fad3f3e31f6e32248d76f964687f0..7f1a580dda2175a42f66aeeab9317001674540b1 100644

--- a/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -2625,7 +2625,7 @@ ScriptValue WebGLRenderingContextBase::getFramebufferAttachmentParameter(ScriptS

case GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME:

return WebGLAny(scriptState, attachmentObject);

case GL_FRAMEBUFFER_ATTACHMENT_COLOR_ENCODING_EXT:

- if (extensionEnabled(EXTsRGBName) || isWebGL2OrHigher()) {

+ if (extensionEnabled(EXTsRGBName)) {

GLint value = 0;

webContext()->getFramebufferAttachmentParameteriv(target, attachment, pname, &value);

return WebGLAny(scriptState, value);