Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1697)

Unified Diff: chrome/android/java/res/layout/data_reduction_promo_screen.xml

Issue 1303213004: New illustrations for the Data Reduction Proxy promo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/res/drawable-xxhdpi/data_reduction_illustration.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/data_reduction_promo_screen.xml
diff --git a/chrome/android/java/res/layout/data_reduction_promo_screen.xml b/chrome/android/java/res/layout/data_reduction_promo_screen.xml
index d0fe45f7a86f06c1d53a087196f5e997a22f8dc7..b2e56d741783e94a17d3b2a7f4a4d3a647b77a0f 100644
--- a/chrome/android/java/res/layout/data_reduction_promo_screen.xml
+++ b/chrome/android/java/res/layout/data_reduction_promo_screen.xml
@@ -35,7 +35,7 @@
android:layout_height="wrap_content"
android:layout_width="match_parent"
android:layout_below="@+id/close_button"
- android:layout_marginTop="8dp"
+ android:layout_marginTop="16dp"
android:orientation="vertical"
android:paddingEnd="24dp"
android:paddingStart="24dp" >
@@ -43,10 +43,13 @@
<ImageView
android:layout_height="wrap_content"
android:layout_width="match_parent"
- android:layout_marginBottom="24dp"
+ android:layout_marginBottom="30dp"
android:adjustViewBounds="true"
android:contentDescription="@null"
android:gravity="center"
+ android:paddingEnd="75dp"
newt (away) 2015/09/02 03:31:00 Why is this padding needed? And why the max heigh
+ android:paddingStart="75dp"
+ android:maxHeight="300dp"
android:src="@drawable/data_reduction_illustration" />
<TextView
« no previous file with comments | « chrome/android/java/res/drawable-xxhdpi/data_reduction_illustration.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698