Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <org.chromium.chrome.browser.widget.PaddedFrameLayout | 6 <org.chromium.chrome.browser.widget.PaddedFrameLayout |
| 7 xmlns:android="http://schemas.android.com/apk/res/android" | 7 xmlns:android="http://schemas.android.com/apk/res/android" |
| 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" | 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" |
| 9 android:background="#c000" | 9 android:background="#c000" |
| 10 chrome:maxChildHeight="@dimen/data_reduction_promo_screen_height" | 10 chrome:maxChildHeight="@dimen/data_reduction_promo_screen_height" |
| (...skipping 17 matching lines...) Expand all Loading... | |
| 28 android:layout_alignParentTop="true" | 28 android:layout_alignParentTop="true" |
| 29 android:background="?android:attr/selectableItemBackground" | 29 android:background="?android:attr/selectableItemBackground" |
| 30 android:contentDescription="@string/close" | 30 android:contentDescription="@string/close" |
| 31 android:src="@drawable/btn_close" /> | 31 android:src="@drawable/btn_close" /> |
| 32 | 32 |
| 33 <LinearLayout | 33 <LinearLayout |
| 34 android:id="@+id/data_reduction_promo_text" | 34 android:id="@+id/data_reduction_promo_text" |
| 35 android:layout_height="wrap_content" | 35 android:layout_height="wrap_content" |
| 36 android:layout_width="match_parent" | 36 android:layout_width="match_parent" |
| 37 android:layout_below="@+id/close_button" | 37 android:layout_below="@+id/close_button" |
| 38 android:layout_marginTop="8dp" | 38 android:layout_marginTop="16dp" |
| 39 android:orientation="vertical" | 39 android:orientation="vertical" |
| 40 android:paddingEnd="24dp" | 40 android:paddingEnd="24dp" |
| 41 android:paddingStart="24dp" > | 41 android:paddingStart="24dp" > |
| 42 | 42 |
| 43 <ImageView | 43 <ImageView |
| 44 android:layout_height="wrap_content" | 44 android:layout_height="wrap_content" |
| 45 android:layout_width="match_parent" | 45 android:layout_width="match_parent" |
| 46 android:layout_marginBottom="24dp" | 46 android:layout_marginBottom="30dp" |
| 47 android:adjustViewBounds="true" | 47 android:adjustViewBounds="true" |
| 48 android:contentDescription="@null" | 48 android:contentDescription="@null" |
| 49 android:gravity="center" | 49 android:gravity="center" |
| 50 android:paddingEnd="75dp" | |
|
newt (away)
2015/09/02 03:31:00
Why is this padding needed?
And why the max heigh
| |
| 51 android:paddingStart="75dp" | |
| 52 android:maxHeight="300dp" | |
| 50 android:src="@drawable/data_reduction_illustration" /> | 53 android:src="@drawable/data_reduction_illustration" /> |
| 51 | 54 |
| 52 <TextView | 55 <TextView |
| 53 android:layout_height="wrap_content" | 56 android:layout_height="wrap_content" |
| 54 android:layout_width="match_parent" | 57 android:layout_width="match_parent" |
| 55 android:layout_marginBottom="8dp" | 58 android:layout_marginBottom="8dp" |
| 56 android:text="@string/data_reduction_promo_title" | 59 android:text="@string/data_reduction_promo_title" |
| 57 android:textColor="@color/default_text_color" | 60 android:textColor="@color/default_text_color" |
| 58 android:textSize="@dimen/data_reduction_promo_title_text_siz e" /> | 61 android:textSize="@dimen/data_reduction_promo_title_text_siz e" /> |
| 59 | 62 |
| (...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 91 android:layout_width="wrap_content" | 94 android:layout_width="wrap_content" |
| 92 android:minHeight="40dp" | 95 android:minHeight="40dp" |
| 93 android:text="@string/data_reduction_enable_button" | 96 android:text="@string/data_reduction_enable_button" |
| 94 android:textColor="#FFFFFF" | 97 android:textColor="#FFFFFF" |
| 95 android:textSize="@dimen/data_reduction_promo_button_text_si ze" | 98 android:textSize="@dimen/data_reduction_promo_button_text_si ze" |
| 96 chrome:buttonColor="@color/light_active_color" /> | 99 chrome:buttonColor="@color/light_active_color" /> |
| 97 </LinearLayout> | 100 </LinearLayout> |
| 98 </RelativeLayout> | 101 </RelativeLayout> |
| 99 </ScrollView> | 102 </ScrollView> |
| 100 </org.chromium.chrome.browser.widget.PaddedFrameLayout> | 103 </org.chromium.chrome.browser.widget.PaddedFrameLayout> |
| OLD | NEW |