content/browser/browser_plugin/browser_plugin_guest.cc - Issue 13032003: Browser Plugin: <webview> should inherit partition attribute of opener on attachment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/browser_plugin/browser_plugin_guest.cc

Issue 13032003: Browser Plugin: <webview> should inherit partition attribute of opener on attachment. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js ('k') | content/common/browser_plugin/browser_plugin_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/browser_plugin/browser_plugin_guest.cc

diff --git a/content/browser/browser_plugin/browser_plugin_guest.cc b/content/browser/browser_plugin/browser_plugin_guest.cc

index 6240790a233b25633524cf4de8fe6533390d4934..e94249dddbc81fd35655aa610d5553f761419a6f 100644

--- a/content/browser/browser_plugin/browser_plugin_guest.cc

+++ b/content/browser/browser_plugin/browser_plugin_guest.cc

@@ -752,11 +752,15 @@ void BrowserPluginGuest::Attach(

GetWebContents()->GetRenderViewHost())->Init();

}

- // Inform the embedder BrowserPlugin of the attached guest.

- if (!name_.empty()) {

- SendMessageToEmbedder(

- new BrowserPluginMsg_UpdatedName(instance_id_, name_));

- }

+ const GURL& site_url = GetWebContents()->GetSiteInstance()->GetSiteURL();

Charlie Reis 2013/04/04 21:30:23 nit: Move this declaration below the comment, and

+ // Inform the embedder of the guest's information.

+ BrowserPluginMsg_Attach_ACK_Params ack_params;

+ ack_params.storage_partition_id = site_url.query();

+ ack_params.persist_storage =

+ site_url.path().find("persist") != std::string::npos;

+ ack_params.name = name_;

+ SendMessageToEmbedder(

+ new BrowserPluginMsg_Attach_ACK(instance_id_, ack_params));

}

void BrowserPluginGuest::OnCompositorFrameACK(