Browser Plugin: <webview> should inherit partition attribute of opener on attachment.

content/browser/browser_plugin/browser_plugin_guest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_plugin/browser_plugin_guest.h"
 
 #include <algorithm>
 
 #include "base/message_loop.h"
 #include "base/string_util.h"
@@ skipping 734 matching lines @@
   Initialize(embedder_web_contents, params);
 
   // We initialize the RenderViewHost after a BrowserPlugin has been attached
   // to it and is ready to receive pixels. Until a RenderViewHost is
   // initialized, it will not allow any resize requests.
   if (!GetWebContents()->GetRenderViewHost()->IsRenderViewLive()) {
     static_cast<RenderViewHostImpl*>(
         GetWebContents()->GetRenderViewHost())->Init();
   }
 
-  // Inform the embedder BrowserPlugin of the attached guest.
-  if (!name_.empty()) {
-    SendMessageToEmbedder(
-        new BrowserPluginMsg_UpdatedName(instance_id_, name_));
-  }
+  const GURL& site_url = GetWebContents()->GetSiteInstance()->GetSiteURL();

[Charlie Reis, 2013/04/04 21:30:23]

nit: Move this declaration below the comment, and add a bit of an explanation of
our assumptions to the comment.  Something like:
We pull the partition information from the site's URL, which is of the form
guest://site/{persist}?{partition_name}.

+  // Inform the embedder of the guest's information.
+  BrowserPluginMsg_Attach_ACK_Params ack_params;
+  ack_params.storage_partition_id = site_url.query();
+  ack_params.persist_storage =
+      site_url.path().find("persist") != std::string::npos;
+  ack_params.name = name_;
+  SendMessageToEmbedder(
+      new BrowserPluginMsg_Attach_ACK(instance_id_, ack_params));
 }
 
 void BrowserPluginGuest::OnCompositorFrameACK(
     int instance_id,
     int route_id,
     int renderer_host_id,
     const cc::CompositorFrameAck& ack) {
   RenderWidgetHostImpl::SendSwapCompositorFrameAck(route_id,
                                                    renderer_host_id,
                                                    ack);
@@ skipping 547 matching lines @@
                    base::Value::CreateStringValue(request_method));
   request_info.Set(browser_plugin::kURL, base::Value::CreateStringValue(url));
 
   SendMessageToEmbedder(
       new BrowserPluginMsg_RequestPermission(instance_id(),
           BrowserPluginPermissionTypeDownload, permission_request_id,
           request_info));
 }
 
 }  // namespace content