Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 1303193004: Revert of Now pulling WebRTC telemetry pages from https instead of http. (Closed)

Created:
3 years, 8 months ago by phoglund_chromium
Modified:
3 years, 8 months ago
Reviewers:
sullivan
CC:
chromium-reviews, posciak+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, telemetry-reviews_chromium.org, tnakamura+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Now pulling WebRTC telemetry pages from https instead of http. (patchset #2 id:20001 of https://codereview.chromium.org/1313873002/ ) Reason for revert: Breaks http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%284%29. Original issue's description: > Now pulling WebRTC telemetry pages from https instead of http. > > https://codereview.chromium.org/1301653005 changed getUserMedia so it > only works for secure origins, which led gUM to be blocked. This patch > makes us pull our demo pages from https instead of http. Web page > replay seems to respect https, and will play back as https, so this > should solve the problem. > > BUG=520765, 523517 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/f0d3f1086f14baddc8914d3683125c65c4eed82c > Cr-Commit-Position: refs/heads/master@{#345350} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=520765, 523517 Committed: https://crrev.com/aaaef28db8754ded3543aead60f75fce9867c99a Cr-Commit-Position: refs/heads/master@{#345611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -12 lines) Patch
M tools/perf/benchmarks/webrtc.py View 1 chunk +2 lines, -0 lines 0 comments Download
M tools/perf/page_sets/data/webrtc_cases.json View 3 chunks +10 lines, -10 lines 0 comments Download
D tools/perf/page_sets/data/webrtc_cases_013.wpr.sha1 View 1 chunk +0 lines, -1 line 0 comments Download
M tools/perf/page_sets/webrtc_cases.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
phoglund_chromium
Created Revert of Now pulling WebRTC telemetry pages from https instead of http.
3 years, 8 months ago (2015-08-26 15:51:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303193004/1
3 years, 8 months ago (2015-08-26 15:51:42 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
3 years, 8 months ago (2015-08-26 15:52:37 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2015-08-26 15:53:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aaaef28db8754ded3543aead60f75fce9867c99a
Cr-Commit-Position: refs/heads/master@{#345611}

Powered by Google App Engine
This is Rietveld 408576698