Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1303193002: [Download Notification] Disable download notification by default on ChromeOS (Closed)

Created:
5 years, 4 months ago by yoshiki
Modified:
5 years, 4 months ago
Reviewers:
fukino
CC:
chromium-reviews, benjhayden+dwatch_chromium.org, asanka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Notification] Disable download notification by default on ChromeOS This patch disables download notification by default on ChromeOS. User still can enable it on chrome://flag explicitly. On the other platform, it has already been disabled by default. BUG=523161 TEST=none TBR=asanka@chromium.org R=fukino@chromium.org Committed: https://crrev.com/175c6d056fdf13de95531b780659ef0692260e1d Cr-Commit-Position: refs/heads/master@{#344727}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/download/notification/download_notification_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yoshiki
Fukino-san, could you take a look? Thanks.
5 years, 4 months ago (2015-08-21 06:37:36 UTC) #2
fukino
lgtm!
5 years, 4 months ago (2015-08-21 07:57:44 UTC) #3
yoshiki
Thanks!
5 years, 4 months ago (2015-08-21 07:58:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303193002/1
5 years, 4 months ago (2015-08-21 07:58:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-21 09:23:25 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 09:24:01 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/175c6d056fdf13de95531b780659ef0692260e1d
Cr-Commit-Position: refs/heads/master@{#344727}

Powered by Google App Engine
This is Rietveld 408576698